Skip to content

feat: add actions to set max and min FPS at runtime #7754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArturKrys wants to merge 1 commit into
base: master
Choose a base branch
from
+40 −0
Open

feat: add actions to set max and min FPS at runtime #7754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Core/GDCore/Extensions/Builtin/TimeExtension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,28 @@ void GD_CORE_API BuiltinExtensionsImplementer::ImplementsTimeExtension(
.AddParameter("expression",
_("Scale (1: Default, 2: 2x faster, 0.5: 2x slower...)"));

extension
.AddAction("SetMaximumFPS",
_("Maximum FPS"),
_("Change the maximum frames per second at runtime."),
_("Set maximum FPS to _PARAM1_"),
_("Rendering"),
"res/actions/fps_max24.png",
"res/actions/fps_max.png")
.AddCodeOnlyParameter("currentScene", "")
.AddParameter("expression", _("Maximum FPS"));

extension
.AddAction("SetMinimumFPS",
_("Minimum FPS"),
_("Change the minimum frames per second at runtime."),
_("Set minimum FPS to _PARAM1_"),
_("Rendering"),
"res/actions/fps_min24.png",
"res/actions/fps_min.png")
.AddCodeOnlyParameter("currentScene", "")
.AddParameter("expression", _("Minimum FPS"));

extension
.AddAction("Wait",
_("Wait X seconds"),
Expand Down
4 changes: 4 additions & 0 deletions GDJS/GDJS/Extensions/Builtin/TimeExtension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ TimeExtension::TimeExtension() {
"gdjs.evtTools.runtimeScene.getTimeScale");
GetAllActions()["ChangeTimeScale"].SetFunctionName(
"gdjs.evtTools.runtimeScene.setTimeScale");
GetAllActions()["SetMaximumFPS"].SetFunctionName(
"gdjs.evtTools.runtimeScene.setMaximumFPS");
GetAllActions()["SetMinimumFPS"].SetFunctionName(
"gdjs.evtTools.runtimeScene.setMinimumFPS");

GetAllExpressions()["TimeDelta"].SetFunctionName(
"gdjs.evtTools.runtimeScene.getElapsedTimeInSeconds");
Expand Down
14 changes: 14 additions & 0 deletions GDJS/Runtime/events-tools/runtimescenetools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,20 @@ namespace gdjs {
return runtimeScene.getScene().getTimeManager().setTimeScale(timeScale);
};

export const setMaximumFPS = function (
runtimeScene: gdjs.RuntimeScene,
fps: float
) {
runtimeScene.getGame()._maxFPS = fps;
};

export const setMinimumFPS = function (
runtimeScene: gdjs.RuntimeScene,
fps: float
) {
runtimeScene.getGame()._minFPS = fps;
};

export const getTimeScale = function (runtimeScene: gdjs.RuntimeScene) {
return runtimeScene.getScene().getTimeManager().getTimeScale();
};
Expand Down