Display the advanced properties for effects in the side panel #8064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D8H
changed the title
D8H
changed the title
4ian
reviewed
Dec 18, 2025
newIDE/app/src/LayersList/CompactLayerPropertiesEditor/CompactEffectsListEditor.js
Outdated
Show resolved
Hide resolved
4ian
reviewed
Dec 18, 2025
| } | ||
| childObject={childObject} | ||
| onRefreshAllFields={forceRecomputeSchema} | ||
| onRefreshAllFields={() => {}} |
Owner
There was a problem hiding this comment.
Looks suspicious, I would probably at least forceUpdate here too?
Collaborator
Author
There was a problem hiding this comment.
The existing implementation was refreshing the parent properties instead of the child ones.
Initially, I didn't want to touch this component because it's almost legacy, but since we'll keep it for a long time, I factorized it too. It will reduce the risk to break something without realizing it since we don't use it much.
4ian
reviewed
Dec 18, 2025
4ian
reviewed
Dec 18, 2025
4ian
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.