[src/MaxText/inference/offline_engine.py] Make OfflineEngine a fluent interface#2983
Open
SamuelMarks wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Open
[src/MaxText/inference/offline_engine.py] Make OfflineEngine a fluent interface#2983SamuelMarks wants to merge 1 commit intoAI-Hypercomputer:mainfrom
OfflineEngine a fluent interface#2983SamuelMarks wants to merge 1 commit intoAI-Hypercomputer:mainfrom
Conversation
…kes many configuration flags ( `enable_batch_prefill`, `min_decode_steps`, `prefill_lengths`, `eos_ids`) to configure internal workers and prefill helpers. The setup logic branches based on these flags (e.g., choosing `BatchedPrefillProcessor` vs `PrefillProcessor`) ; [tests/{grpo_trainer_correctness_test.py,inference/benchmark_offline_engine.py,offline_engine_test.py}] Update tests for new fluent interface
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[src/MaxText/inference/offline_engine.py]
OfflineEngine.__init__takes many configuration flags (enable_batch_prefill,min_decode_steps,prefill_lengths,eos_ids) to configure internal workers and prefill helpers. The setup logic branches based on these flags (e.g., choosingBatchedPrefillProcessorvsPrefillProcessor) ; [tests/{grpo_trainer_correctness_test.py,inference/benchmark_offline_engine.py,offline_engine_test.py}] Update tests for new fluent interfaceTL;DR: Instead of passing a long list of arguments (some mutually exclusive or dependent on flags like
enable_batch_prefill) directly to__init__, we now use a Builder pattern. This validates configuration (e.g. checkingscan_layersvsbatch_prefill) before the engine is created.Before:
After:
Tests
CI
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.