Print logic axes#2985
Merged
copybara-service[bot] merged 9 commits intoAI-Hypercomputer:mainfrom Jan 28, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
6433043 to
6591621
Compare
xibinliu
reviewed
Jan 22, 2026
dcb87fc to
d0644bc
Compare
richjames0
approved these changes
Jan 27, 2026
Collaborator
richjames0
left a comment
There was a problem hiding this comment.
lgtm although note my pending comment
NuojCheng
reviewed
Jan 27, 2026
NuojCheng
reviewed
Jan 27, 2026
NuojCheng
reviewed
Jan 27, 2026
NuojCheng
reviewed
Jan 27, 2026
NuojCheng
reviewed
Jan 27, 2026
NuojCheng
reviewed
Jan 27, 2026
Collaborator
NuojCheng
left a comment
There was a problem hiding this comment.
Thank you for the PR! Made some comments and suggestions. It would be nice to add a real train test in the PR description.
Collaborator
Author
Thanks for the suggestion. Add a real train log. Please check. |
NuojCheng
approved these changes
Jan 28, 2026
be0bb6a to
d84d4ca
Compare
fcb87c0
into
AI-Hypercomputer:main
21 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change builds upon PR#2866 and PR#2926 to add functionality for printing logical axes
Tests
Command:
python -m MaxText.train_compile MaxText/configs/base.yml compile_topology=v5p-1024 compile_topology_num_slices=1 model_name=deepseek3-671b per_device_batch_size=1 ici_tensor_parallelism=8 ici_expert_parallelism=8 log_config=false debug_sharding=trueOutput example:
Log for a real train: https://paste.googleplex.com/6519526529302528
Weight with Logic axes:
Activation Logical Axes:
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.