Skip to content

Truncate out_sharding to match tensor ndim when pspec has extra dimensions. - #4769

Merged
copybara-service[bot] merged 1 commit into
mainfrom
test_960571888
Aug 7, 2026
Merged

Truncate out_sharding to match tensor ndim when pspec has extra dimensions.#4769
copybara-service[bot] merged 1 commit into
mainfrom
test_960571888

Conversation

@copybara-service

@copybara-service copybara-service Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Truncate out_sharding to match tensor ndim when pspec has extra dimensions.

@codecov

codecov Bot commented Aug 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/maxtext/utils/sharding.py 80.00% 0 Missing and 3 partials ⚠️
src/maxtext/layers/embeddings.py 60.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@copybara-service
copybara-service Bot merged commit 8da934d into main Aug 7, 2026
1 check passed
@copybara-service
copybara-service Bot deleted the test_960571888 branch August 7, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parambole parambole Awaiting requested review from parambole parambole is a code owner
@shuningjin shuningjin Awaiting requested review from shuningjin shuningjin is a code owner
@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner
@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner
@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner
@bvandermoon bvandermoon Awaiting requested review from bvandermoon bvandermoon is a code owner
@gagika gagika Awaiting requested review from gagika gagika is a code owner
@shralex shralex Awaiting requested review from shralex shralex is a code owner
@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner
@NuojCheng NuojCheng Awaiting requested review from NuojCheng NuojCheng is a code owner
@xibinliu xibinliu Awaiting requested review from xibinliu xibinliu is a code owner
@huytransformer huytransformer Awaiting requested review from huytransformer huytransformer is a code owner
@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner
@igorts-git igorts-git Awaiting requested review from igorts-git igorts-git is a code owner
@abhinavclemson abhinavclemson Awaiting requested review from abhinavclemson abhinavclemson is a code owner
@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner
@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner
@SurbhiJainUSC SurbhiJainUSC Awaiting requested review from SurbhiJainUSC SurbhiJainUSC is a code owner
@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner
@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner
@dipannita08 dipannita08 Awaiting requested review from dipannita08 dipannita08 is a code owner
@darisoy darisoy Awaiting requested review from darisoy darisoy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Google-ML-Automation