Security Fix: Remap UNSANDBOXED mode to V8 Isolate to prevent RCE #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request patches a Critical Remote Code Execution (RCE) vulnerability in the execution engine.
The Vulnerability:
The default configuration (
UNSANDBOXEDmode) previously usednoOpCodeSandbox, which relies on theFunctionconstructor. This allowed user-supplied code to access the host processprocess.envand execute arbitrary commands.The Fix:
I have updated the
loadCodeSandboxfunction to mapUNSANDBOXEDandSANDBOXEDmodes toloadV8IsolateSandbox. This ensures that even in default configurations, user code is executed within a secure V8 Isolate, preventing unauthorized access to the host server.Type of Change