Fix/remove docker secrets #392
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During a security audit, I identified a High-Severity vulnerability where production secrets were hardcoded directly into
workflow/docker-compose.yml.Vulnerability:
The following sensitive credentials were exposed in plain text:
POSTGRES_PASSWORDJWT_SECRET(Critical for session security)ENCRYPTION_KEYImpact:
Any user who clones this repository receives these keys. If this configuration is deployed to production (as the
docker-composefilename suggests), the application is immediately compromised. Attackers could forge session tokens (JWT_SECRET) or access the database directly (POSTGRES_PASSWORD).The Fix:
I have removed all hardcoded values and replaced them with environment variable references (e.g.,
${POSTGRES_PASSWORD}). This forces the administrator to provide these secrets securely via a.envfile or the environment, following the 12-Factor App security principles.Type of Change