fix: Add fallback to search for timecode in FFmpeg format context metadata#1193
Merged
bernie-laberge merged 1 commit intoAcademySoftwareFoundation:RB-2.2.0-VFX2023from Mar 7, 2026
Conversation
bernie-laberge
requested review from
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
…AcademySoftwareFoundation#887) n/a When the streams metadata do not have the timecode information, I added a fallback mechanism that looks at the format context metadata and try to find the `timecode` information. During testing, there were some MXF media files that had the wrong start time. MacOS attention during the review. --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Signed-off-by: Bernard Laberge <bernard.laberge@autodesk.com>
bernie-laberge
force-pushed
the
cherry_pick_metadata_fix
branch
from
d8c94cc to
3750d5f
Compare
cedrik-fuoco-adsk
approved these changes
Mar 6, 2026
eloisebrosseau
approved these changes
Mar 6, 2026
bernie-laberge
merged commit b04b7b9
into
AcademySoftwareFoundation:RB-2.2.0-VFX2023
14 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this is a cherry pick from the main branch:
1cbff48
Add fallback to search for timecode in FFmpeg context metadata
Linked issues
n/a
Summarize your change.
When the streams metadata do not have the timecode information, I added
a fallback mechanism that looks at the format context metadata and try
to find the
timecodeinformation.Describe the reason for the change.
During testing, there were some MXF media files that had the wrong start
time.
Describe what you have tested and on which operating system.
MacOS
Add a list of changes, and note any that might need special
attention during the review.
If possible, provide screenshots.
Signed-off-by: Cédrik Fuoco cedrik.fuoco@autodesk.com