feat: SG-42883: [RV] Leverage if thumbnail is already existing along-side the media#1225
Draft
chenlj1 wants to merge 22 commits intoAcademySoftwareFoundation:mainfrom
Draft
feat: SG-42883: [RV] Leverage if thumbnail is already existing along-side the media#1225chenlj1 wants to merge 22 commits intoAcademySoftwareFoundation:mainfrom
chenlj1 wants to merge 22 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
…style to qss files Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
…sable Signed-off-by: chenl1 <ling.jie.chen@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SG-42883: [RV] Leverage if thumbnail is already existing along-side the media
Summarize your change.
Added an optional persistent cache for generated thumbnails and filmstrips in local_thumbnail_gen.py.
When the
RV_PERSISTENT_PREVIEW_CACHEenvironment variable is set, previews are saved to an rv_previews/ folder next to the source media instead of a temporary directory. This allows previews to be reused across RV sessions instead of being regenerated each time.Describe the reason for the change.
Previously, previews were stored in a temp directory and deleted after each session. We wanted to add an option for persistent caching to avoid unnecessary regeneration and improves load times.
Describe what you have tested and on which operating system.
Tested on macOS to confirm that default temp file behavior remains unchanged when
RV_PERSISTENT_PREVIEW_CACHEis not set.When the env var is enabled, verified that the persistent
rv_previews/directory is created for each local source and that previews are reused across sessions without regeneration.