Feature: add part indices to pyapi#2149
Open
dendenxu wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Open
Feature: add part indices to pyapi#2149dendenxu wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
dendenxu wants to merge 2 commits intoAcademySoftwareFoundation:mainfrom
Conversation
This commit fixes the issue where an unfinished multi-part file could not be loaded properly in the python warpper for OpenEXR. This happens when headers for the multi-part file are written to disk but the actual pixels never finish being written. The current fix skips the corrupted or empty parts with no pixel data while retaining the ability for loading the correct ones. Signed-off-by: dendenxu <zhenx@zju.edu.cn>
This can specify the specific parts of a multi-part EXR file to be loaded to avoid excessive IO when only some parts of the file is needed by the program. This functionality could be particular useful when the file is very large and only a very small portion of it is required in memory. Signed-off-by: dendenxu <zhenx@zju.edu.cn>
Member
|
This looks fine, but I'd like to have a test to validate the behavior. Can you add a test to src/wrappers/python/tests/test_unittest.py? Your test file is 268Mb, that's too big to add to the test suite. Either come up with a much smaller file, or just have the test generate a file on the fly and then test reading it. |
Author
|
Make sense! The large test file is mainly there to show the difference in IO performance between naively reading all parts or doing so more selectively. I'll let the test suite randomly generate a test file to test this. |
Member
|
I'd like to accept this feature, if you can add the associated tests. Same for #2148. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add part_indices for the Python File API
This can specify the specific parts of a multi-part EXR file to be loaded to avoid excessive IO when only some parts of the file are needed by the program. This functionality could be particularly useful when the file is very large, and only a very small portion of it is required in memory.
Test EXR file:
https://drive.google.com/file/d/1A0ciiL0BeF0RA6Do-8sd81slqdckdP0p/view?usp=sharing
Test script: