Skip to content

fix(lsp): improve custom server transport setup #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 3 commits into from
Mar 31, 2026
Merged

fix(lsp): improve custom server transport setup #1998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
065fc6a
fix(lsp): improve custom server transport setup
bajrangCoder Mar 31, 2026
eeb65cf
remove the lsp document highlights
bajrangCoder Mar 31, 2026
4bb0ac8
fix
bajrangCoder Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/cm/lsp/clientManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import lspStatusBar from "components/lspStatusBar";
import NotificationManager from "lib/notificationManager";
import Uri from "utils/Uri";
import { clearDiagnosticsEffect } from "./diagnostics";
import { documentHighlightsExtension } from "./documentHighlights";
import { supportsBuiltinFormatting } from "./formattingSupport";
import { inlayHintsExtension } from "./inlayHints";
import { acodeRenameKeymap } from "./rename";
Expand Down Expand Up @@ -160,7 +159,6 @@ function buildBuiltinExtensions(
keymaps: includeKeymaps = true,
diagnostics: includeDiagnostics = true,
inlayHints: includeInlayHints = false,
documentHighlights: includeDocumentHighlights = true,
formatting: includeFormatting = true,
} = config;

Expand Down Expand Up @@ -190,10 +188,6 @@ function buildBuiltinExtensions(
const hintsExt = inlayHintsExtension();
extensions.push(hintsExt as LSPClientExtension as Extension);
}
if (includeDocumentHighlights) {
const highlightsExt = documentHighlightsExtension();
extensions.push(highlightsExt as LSPClientExtension as Extension);
}

return { extensions, diagnosticsExtension };
}
Expand Down Expand Up @@ -530,7 +524,6 @@ export class LspClientManager {
keymaps: builtinConfig.keymaps !== false,
diagnostics: builtinConfig.diagnostics !== false,
inlayHints: builtinConfig.inlayHints === true,
documentHighlights: builtinConfig.documentHighlights !== false,
formatting: builtinConfig.formatting !== false,
})
: { extensions: [], diagnosticsExtension: null };
Expand Down
342 changes: 0 additions & 342 deletions src/cm/lsp/documentHighlights.ts
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions src/cm/lsp/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ export {
lspDiagnosticsExtension,
lspDiagnosticsUiExtension,
} from "./diagnostics";
export type { DocumentHighlightsConfig } from "./documentHighlights";
export {
documentHighlightsClientExtension,
documentHighlightsEditorExtension,
documentHighlightsExtension,
} from "./documentHighlights";
export type {
DocumentSymbolsResult,
FlatSymbol,
Expand Down
Loading