Repository navigation
test(server): guard long-event overlap consumers - #215
Draft
TimeToBuildBob wants to merge 2 commits into
Draft
TimeToBuildBob wants to merge 2 commits into
TimeToBuildBob wants to merge 2 commits into
Conversation
Git-Session-Id: d8a22e8f-4386-4789-bab9-5ddd743d4b08
[Low impact] The changes affect the server's test coverage, not its runtime behavior. The review found one non-blocking test gap: CSV and AQL should also check that reads leave the saved event unchanged. Findings
SummaryAdds four Flask HTTP regressions for a 48-hour event queried inside its second day.
TimeToBuildBob explicitly keeps the PR draft because the locked Reviews (1) · Last reviewed commit: "test(server): guard long-event overlap c..." · Reviewed by Greptile |
Git-Session-Id: 4cb0ead5-8800-5d0b-ae25-627bf2fd2fdf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration regressions for #213 and ActivityWatch/aw-core#194; depends on core repair ActivityWatch/aw-core#197.
Adds real Flask HTTP tests against a disposable Peewee database for a 48-hour event queried wholly inside its second day:
sum_durations(query_bucket(...))andquery_bucket_eventcount(...).The tests preserve existing clipped Peewee behavior (one-hour interior result), not full-duration AQL semantics. Reads must not alter the stored 48-hour event.
make testexplicitly runs the new file, so it cannot silently miss CI.Verification
make testwith repaired core: 148 passed;make typecheck: 32 files clean.test_client.py: 231 passed with repaired core.Deliberate merge gate
Draft until an aw-core dependency containing ActivityWatch/aw-core#197 is available and adopted. The locked aw-core 0.5.18 still has the defect, so these tests are expected RED with the unmodified lock. Do not merge a test suite that requires an unshipped dependency. No server production-code change or temporary version skip is proposed; the required follow-through is update the dependency/lock after a containing core release, replay this suite, then mark ready.