[posmobile] Code generation: update services and models#1629
[posmobile] Code generation: update services and models#1629AdyenAutomationBot wants to merge 2 commits intomainfrom
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a series of automated code generation changes. While many of these changes improve code style, such as standardizing indentation to 4 spaces, there are several issues introduced across multiple files. These include high-severity issues like empty statements in equals methods, which are confusing and suggest a bug in the code generator. Additionally, there are numerous formatting problems in Javadocs, such as malformed comment blocks, extremely long lines that hurt readability, and inconsistent method body styling. These issues suggest problems with the code generation templates or configuration that should be addressed to ensure the generated code is correct and maintainable.
| Objects.equals(this.isSetSetupToken, createSessionRequest.isSetSetupToken) && | ||
| Objects.equals(this.store, createSessionRequest.store) && | ||
| Objects.equals(this.isSetStore, createSessionRequest.isSetStore) | ||
| ; |
There was a problem hiding this comment.
This empty statement is unnecessary and confusing. It appears to be a code generation artifact and should be removed. While it doesn't cause a compilation error, it makes the code harder to understand.
| Objects.equals(this.isSetSdkData, createSessionResponse.isSetSdkData) && | ||
| Objects.equals(this.store, createSessionResponse.store) && | ||
| Objects.equals(this.isSetStore, createSessionResponse.isSetStore) | ||
| ; |
There was a problem hiding this comment.
This empty statement is unnecessary and confusing. It appears to be a code generation artifact and should be removed. While it doesn't cause a compilation error, it makes the code harder to understand.
| * API](https://docs.adyen.com/point-of-sale/design-your-integration/terminal-api/) transaction | ||
| * request on your backend, use this as the `POIID` in the `MessageHeader` of | ||
| * the request. | ||
| * The unique identifier of the SDK installation. If you create the [Terminal API](https://docs.adyen.com/point-of-sale/design-your-integration/terminal-api/) transaction request on your backend, use this as the `POIID` in the `MessageHeader` of the request. |
There was a problem hiding this comment.
This Javadoc line is very long and harms readability. It should be wrapped to fit within a reasonable line length limit (e.g., 100-120 characters). The previous multi-line format was more readable.
| * @return an instance of the actual schema/object | ||
| */ | ||
| @JsonValue | ||
| public Object getActualInstance() {return instance;} |
There was a problem hiding this comment.
For consistency and readability, it's better to place the method body on a new line, even for single-line methods. This is a common practice in Java style guides.
public Object getActualInstance() {
return instance;
}| * `AuthenticationService`. - When using the iOS POS Mobile SDK, obtain the token | ||
| * through the `PaymentServiceDelegate.register(with:)` callback of | ||
| * `PaymentServiceDelegate`. | ||
| * The setup token provided by the POS Mobile SDK. - When using the Android POS Mobile SDK, obtain the token through the `AuthenticationService.authenticate(setupToken)` callback of `AuthenticationService`. - When using the iOS POS Mobile SDK, obtain the token through the `PaymentServiceDelegate.register(with:)` callback of `PaymentServiceDelegate`. |
There was a problem hiding this comment.
This Javadoc line is very long and harms readability. It should be wrapped to fit within a reasonable line length limit (e.g., 100-120 characters). The previous multi-line format was more readable.
| public static ObjectMapper getMapper() { | ||
| return mapper; | ||
| } | ||
| public static ObjectMapper getMapper() { return mapper; } |
There was a problem hiding this comment.
For consistency and readability, it's better to place the method body on a new line, even for single-line methods. This is a common practice in Java style guides.
public static ObjectMapper getMapper() {
return mapper;
}| static | ||
| { |
There was a problem hiding this comment.
The formatting of this static block is unconventional. Standard Java formatting places the opening brace on the same line as the static keyword (static {) or on the next line, but not with static and { on separate lines.
static {| /** | ||
| * Create a communication session | ||
| * | ||
| * @param createSessionRequest {@link CreateSessionRequest } (required) |
There was a problem hiding this comment.
The Javadoc has extra spaces around the {@link} tag. These should be removed for cleaner formatting.
| * @param createSessionRequest {@link CreateSessionRequest } (required) | |
| * @param createSessionRequest {@link CreateSessionRequest} (required) |
| * Create a communication session | ||
| * | ||
| * @param createSessionRequest {@link CreateSessionRequest } (required) | ||
There was a problem hiding this comment.
This blank line in the Javadoc is unnecessary and should be removed.
| /** | ||
| * Create a communication session | ||
| * | ||
| * @param createSessionRequest {@link CreateSessionRequest } (required) |
There was a problem hiding this comment.
The Javadoc has extra spaces around the {@link} tag. These should be removed for cleaner formatting.
| * @param createSessionRequest {@link CreateSessionRequest } (required) | |
| * @param createSessionRequest {@link CreateSessionRequest} (required) |
AdyenAutomationBot
force-pushed
the
sdk-automation/posmobile
branch
4 times, most recently
from
7d1b0a3 to
bffcbfc
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/posmobile
branch
from
9035f27 to
9514daf
Compare
2 participants
This PR contains the automated changes for the
posmobileservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.