[configurationwebhooks] Code generation: update services and models#1637
[configurationwebhooks] Code generation: update services and models#1637jeandersonbc merged 2 commits intomainfrom
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers automated code updates for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, an automated update from a code generator, introduces several formatting issues that reduce code readability. The most common problems are excessive blank lines and extremely long single-line hashCode methods. While the change to 4-space indentation is a good improvement, these formatting regressions should be addressed in the generator. I've added comments on a few examples, but these issues are widespread across the modified files.
|
|
||
|
|
||
|
|
| status, | ||
| timeZone, | ||
| verificationDeadlines); | ||
| return Objects.hash(balancePlatform, capabilities, contactDetails, description, id, legalEntityId, metadata, migratedAccountHolderCode, primaryBalanceAccount, reference, status, timeZone, verificationDeadlines); |
There was a problem hiding this comment.
This line is excessively long, which harms readability. It's better to break it into multiple lines, similar to the previous version of this method.
| return Objects.hash(balancePlatform, capabilities, contactDetails, description, id, legalEntityId, metadata, migratedAccountHolderCode, primaryBalanceAccount, reference, status, timeZone, verificationDeadlines); | |
| return Objects.hash( | |
| balancePlatform, | |
| capabilities, | |
| contactDetails, | |
| description, | |
| id, | |
| legalEntityId, | |
| metadata, | |
| migratedAccountHolderCode, | |
| primaryBalanceAccount, | |
| reference, | |
| status, | |
| timeZone, | |
| verificationDeadlines); | |
| requestedSettings, | ||
| transferInstruments, | ||
| verificationStatus); | ||
| return Objects.hash(allowed, allowedLevel, allowedSettings, enabled, problems, requested, requestedLevel, requestedSettings, transferInstruments, verificationStatus); |
There was a problem hiding this comment.
This line is too long, making it hard to read. Please wrap it to adhere to standard line length limits.
| return Objects.hash(allowed, allowedLevel, allowedSettings, enabled, problems, requested, requestedLevel, requestedSettings, transferInstruments, verificationStatus); | |
| return Objects.hash( | |
| allowed, | |
| allowedLevel, | |
| allowedSettings, | |
| enabled, | |
| problems, | |
| requested, | |
| requestedLevel, | |
| requestedSettings, | |
| transferInstruments, | |
| verificationStatus); | |
| statusComment, | ||
| statusReason, | ||
| type); | ||
| return Objects.hash(additionalBankAccountIdentifications, balanceAccountId, bankAccount, card, description, id, issuingCountryCode, paymentInstrumentGroupId, reference, replacedById, replacementOfId, status, statusComment, statusReason, type); |
There was a problem hiding this comment.
This line is excessively long and should be wrapped for better readability, similar to how it was formatted before this change.
| return Objects.hash(additionalBankAccountIdentifications, balanceAccountId, bankAccount, card, description, id, issuingCountryCode, paymentInstrumentGroupId, reference, replacedById, replacementOfId, status, statusComment, statusReason, type); | |
| return Objects.hash( | |
| additionalBankAccountIdentifications, | |
| balanceAccountId, | |
| bankAccount, | |
| card, | |
| description, | |
| id, | |
| issuingCountryCode, | |
| paymentInstrumentGroupId, | |
| reference, | |
| replacedById, | |
| replacementOfId, | |
| status, | |
| statusComment, | |
| statusReason, | |
| type); | |
|
|
||
|
|
||
|
|
61b28ce to
c45439d
Compare
c45439d to
6b7247e
Compare
6b7247e to
2189f80
Compare
|
Double-checked with @gcatanese: technically this is a breaking change due to the removal of enums, however, these values were never sent from the backend |
This PR contains the automated changes for the
configurationwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.