[managementwebhooks] Code generation: update services and models#1648
[managementwebhooks] Code generation: update services and models#1648AdyenAutomationBot wants to merge 2 commits intomainfrom
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers automated code generation updates for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request contains automated changes from a code generator. The changes are mostly stylistic, improving formatting and consistency across the codebase. However, I've noticed a recurring issue in the generated equals methods, where an unnecessary trailing semicolon is added. This seems to be a bug in the generator and should be fixed to improve code quality.
| Objects.equals(this.requestedLevel, accountCapabilityData.requestedLevel) && | ||
| Objects.equals(this.verificationDeadline, accountCapabilityData.verificationDeadline) && | ||
| Objects.equals(this.verificationStatus, accountCapabilityData.verificationStatus) | ||
| ; |
There was a problem hiding this comment.
The trailing semicolon on this line is unnecessary and can be removed. It creates an empty statement which has no effect and can be confusing.
| Objects.equals(this.legalEntityId, accountCreateNotificationData.legalEntityId) && | ||
| Objects.equals(this.merchantId, accountCreateNotificationData.merchantId) && | ||
| Objects.equals(this.status, accountCreateNotificationData.status) | ||
| ; |
There was a problem hiding this comment.
The trailing semicolon on this line is unnecessary and can be removed. It creates an empty statement which has no effect and can be confusing.
| return Objects.equals( | ||
| this.notificationResponse, accountNotificationResponse.notificationResponse); | ||
| return Objects.equals(this.notificationResponse, accountNotificationResponse.notificationResponse) | ||
| ; |
There was a problem hiding this comment.
The trailing semicolon on this line is unnecessary and can be removed. It creates an empty statement which has no effect and can be confusing.
| Objects.equals(this.legalEntityId, accountUpdateNotificationData.legalEntityId) && | ||
| Objects.equals(this.merchantId, accountUpdateNotificationData.merchantId) && | ||
| Objects.equals(this.status, accountUpdateNotificationData.status) | ||
| ; |
There was a problem hiding this comment.
The trailing semicolon on this line is unnecessary and can be removed. It creates an empty statement which has no effect and can be confusing.
| && Objects.equals(this.verificationErrors, capabilityProblem.verificationErrors); | ||
| return Objects.equals(this.entity, capabilityProblem.entity) && | ||
| Objects.equals(this.verificationErrors, capabilityProblem.verificationErrors) | ||
| ; |
There was a problem hiding this comment.
The trailing semicolon on this line is unnecessary and can be removed. It creates an empty statement which has no effect and can be confusing.
| Objects.equals(this.terminalId, terminalSettingsData.terminalId) && | ||
| Objects.equals(this.updateSource, terminalSettingsData.updateSource) && | ||
| Objects.equals(this.user, terminalSettingsData.user) | ||
| ; |
There was a problem hiding this comment.
The trailing semicolon on this line is unnecessary and can be removed. It creates an empty statement which has no effect and can be confusing.
| Objects.equals(this.data, terminalSettingsNotificationRequest.data) && | ||
| Objects.equals(this.environment, terminalSettingsNotificationRequest.environment) && | ||
| Objects.equals(this.type, terminalSettingsNotificationRequest.type) | ||
| ; |
There was a problem hiding this comment.
The trailing semicolon on this line is unnecessary and can be removed. It creates an empty statement which has no effect and can be confusing.
| this.notificationResponse, terminalSettingsNotificationResponse.notificationResponse); | ||
| TerminalSettingsNotificationResponse terminalSettingsNotificationResponse = (TerminalSettingsNotificationResponse) o; | ||
| return Objects.equals(this.notificationResponse, terminalSettingsNotificationResponse.notificationResponse) | ||
| ; |
There was a problem hiding this comment.
The trailing semicolon on this line is unnecessary and can be removed. It creates an empty statement which has no effect and can be confusing.
| Objects.equals(this.remediatingActions, verificationError.remediatingActions) && | ||
| Objects.equals(this.subErrors, verificationError.subErrors) && | ||
| Objects.equals(this.type, verificationError.type) | ||
| ; |
There was a problem hiding this comment.
The trailing semicolon on this line is unnecessary and can be removed. It creates an empty statement which has no effect and can be confusing.
| Objects.equals(this.message, verificationErrorRecursive.message) && | ||
| Objects.equals(this.type, verificationErrorRecursive.type) && | ||
| Objects.equals(this.remediatingActions, verificationErrorRecursive.remediatingActions) | ||
| ; |
There was a problem hiding this comment.
The trailing semicolon on this line is unnecessary and can be removed. It creates an empty statement which has no effect and can be confusing.
AdyenAutomationBot
force-pushed
the
sdk-automation/managementwebhooks
branch
4 times, most recently
from
67d8273 to
0b79c23
Compare
AdyenAutomationBot
force-pushed
the
sdk-automation/managementwebhooks
branch
from
349110d to
715353c
Compare
2 participants
This PR contains the automated changes for the
managementwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.