Skip to content

Comments

DPL: clean up leftovers from input stream after parsing a workflow#15087

Open
ehellbar wants to merge 1 commit intoAliceO2Group:devfrom
ehellbar:pr15087
Open

DPL: clean up leftovers from input stream after parsing a workflow#15087
ehellbar wants to merge 1 commit intoAliceO2Group:devfrom
ehellbar:pr15087

Conversation

@ehellbar
Copy link
Collaborator

@ehellbar ehellbar commented Feb 20, 2026

No description provided.

@ehellbar ehellbar requested a review from a team as a code owner February 20, 2026 15:26
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ehellbar
Copy link
Collaborator Author

ehellbar commented Feb 20, 2026

for certain piped workflows, when I use debug severity, there are some leftover debug log messages from destructors after the parsing, which makes the parsing fail and throw the runtime error.

E.g. there are messages from FairRoot and the CcdbApi:

[WARN] following line found  in input stream after parsing workflow: EBUG] removed RTDB container factory ContainerFactory
[WARN] following line found  in input stream after parsing workflow: [DEBUG] Cleaning up semaphore registry with count 0
[WARN] following line found  in input stream after parsing workflow: [DEBUG] removed RTDB container factory MagFieldContFact
[WARN] following line found  in input stream after parsing workflow: [DEBUG] removed RTDB container factory FairBaseContFact

}
LOG(debug) << "following leftover line found in input stream after parsing workflow: " << buf;
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also just not print the lines

if (s.eof()) {
break;
}
LOG(debug) << "following leftover line found in input stream after parsing workflow: " << buf;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using a signpost, so that we actually can turn it on if needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants