Skip to content

Clusterer will prioritize labels with lower trackIndex #15782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Sep 10, 2026
+21 −13
Merged

Clusterer will prioritize labels with lower trackIndex #15782

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions Detectors/ITSMFT/common/reconstruction/src/Clusterer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ void Clusterer::ClustererThread::process(uint16_t chip, uint16_t nChips, CompClu
if (stats.empty() || stats.back().firstChip + stats.back().nChips != chip) { // there is a jump, register new block
stats.emplace_back(ThreadStat{.firstChip = chip, .nChips = 0, .firstClus = uint32_t(compClusPtr->size()), .firstPatt = patternsPtr ? uint32_t(patternsPtr->size()) : 0, .nClus = 0, .nPatt = 0});
}

for (int ic = 0; ic < nChips; ic++) {
auto* curChipData = parent->mFiredChipsPtr[chip + ic];
auto chipID = curChipData->getChipID();
Expand Down Expand Up @@ -316,7 +317,7 @@ void Clusterer::ClustererThread::finishChipSingleHitFast(uint32_t hit, ChipPixel
int nlab = 0;
fetchMCLabels(curChipData->getStartID() + hit, labelsDigPtr, nlab);
auto cnt = compClusPtr->size();
for (int i = nlab; i--;) {
for (int i = 0; i < nlab; i++) {
labelsClusPtr->addElement(cnt, labelsBuff[i]);
}
}
Expand Down Expand Up @@ -436,20 +437,27 @@ void Clusterer::ClustererThread::updateChip(const ChipPixelData* curChipData, ui
void Clusterer::ClustererThread::fetchMCLabels(int digID, const ConstMCTruth* labelsDig, int& nfilled)
{
// transfer MC labels to cluster
if (nfilled >= MaxLabels) {
return;
}
const auto& lbls = labelsDig->getLabels(digID);
for (int i = lbls.size(); i--;) {
int ic = nfilled;
for (; ic--;) { // check if the label is already present
if (labelsBuff[ic] == lbls[i]) {
return; // label is found, do nothing
auto sortBuffer = [this]() { std::sort(this->labelsBuff.begin(), this->labelsBuff.end(), [](Label const& a, Label const& b) { return a.getTrackID() < b.getTrackID(); }); };
for (const auto& l : labelsDig->getLabels(digID)) {
bool skip = false;
for (int ic = 0; ic < nfilled; ic++) { // check if the label is already present
if (labelsBuff[ic] == l) {
skip = true;
break;
}
}
labelsBuff[nfilled++] = lbls[i];
if (nfilled >= MaxLabels) {
break;
if (!skip) { // are there still slots to add it?
if (nfilled < MaxLabels) {
labelsBuff[nfilled++] = l;
if (nfilled == MaxLabels) { // we filled the buffer, sort labels in the trackID increasing order, to increase chances of not losing more primary at next filling
sortBuffer();
}
} else { // buffer is full and sorted in trackID increasing order, substitute the old highest track ID if it is higher than the new label
if (labelsBuff.back().getTrackID() > l.getTrackID()) {
labelsBuff.back() = l; // substitute and re-sort
sortBuffer();
}
}
}
}
//
Expand Down
Loading