[EMCAL-688] Improve ClusterFactory evalDispersion function - #15788
Open
mhemmer-cern wants to merge 1 commit into
Open
[EMCAL-688] Improve ClusterFactory evalDispersion function#15788mhemmer-cern wants to merge 1 commit into
evalDispersion function#15788mhemmer-cern wants to merge 1 commit into
Conversation
mhemmer-cern
force-pushed
the
EMCAL-688
branch
from
September 11, 2026 15:40
1869dfa to
e9b0125
Compare
mhemmer-cern
added a commit
to mhemmer-cern/AliceO2
that referenced
this pull request
Sep 11, 2026
Please consider the following formatting changes to AliceO2Group#15788
mhemmer-cern
force-pushed
the
EMCAL-688
branch
from
September 11, 2026 21:33
f06c21d to
a6968b6
Compare
- Remove TMath calls with std function calls - Fix wrong comments for `thetaToEta` and `etaToTheta` in the .cxx - Update `evalDispersion` function to calculate weights, eta and phi per cell only once in a single loop instead of having two loops
mhemmer-cern
force-pushed
the
EMCAL-688
branch
from
September 11, 2026 21:35
a6968b6 to
9d15d37
Compare
mhemmer-cern
marked this pull request as ready for review
September 11, 2026 22:32
Contributor
Author
|
macOS-arm build seems to fail due to something unrelated to this PR |
mhemmer-cern
changed the title
evalDispersion function
mhemmer-cern
changed the title
evalDispersion functionevalDispersion function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thetaToEtaandetaToThetain the .cxxevalDispersionfunction to calculate weights, eta and phi per cell only once in a single loop instead of having two loops