[O2B-1534] Migrate log overview to use filtering model pattern by NarrowsProjects · Pull Request #2083 · AliceO2Group/Bookkeeping

NarrowsProjects · 2026-02-20T11:53:37Z

I have a JIRA ticket

branch and/or PR name(s) include(s) JIRA ID
issue has "Fix version" assigned
issue "Status" is set to "In review"
PR labels are selected

Notable changes for users:

Individual from-to selectors on the logs page have been replaced with a single field that will open the standard time range selector
All open-input forms apply their filters when focus is lost on them.

Notable changes for developers:

All filters have been moved to a filteringModel in logsOverviewModel
The filters for runs, lhcfills and environments have been renamed under the hood to match getAllRunsUseCase:
- runs => runNumbers
- lhcFills => fillNumbers
- environments => environmentIds

Changes made to the database:

none

codecov · 2026-02-20T11:55:29Z

Codecov Report

❌ Patch coverage is 27.11864% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.75%. Comparing base (47203c7) to head (a40f51f).

Files with missing lines	Patch %	Lines
...ib/public/views/Logs/Overview/LogsOverviewModel.js	0.00%	11 Missing ⚠️
...blic/views/Logs/ActiveColumns/logsActiveColumns.js	0.00%	8 Missing ⚠️
...nts/Filters/LogsFilter/author/AuthorFilterModel.js	0.00%	6 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js	0.00%	5 Missing ⚠️
...mponents/Filters/LogsFilter/author/authorFilter.js	0.00%	3 Missing ⚠️
...onments/ActiveColumns/environmentsActiveColumns.js	0.00%	3 Missing ⚠️
...ic/components/Filters/common/filters/textFilter.js	0.00%	2 Missing ⚠️
...mponents/Filters/common/filters/textInputFilter.js	0.00%	2 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js	0.00%	2 Missing ⚠️
...ataPasses/ActiveColumns/dataPassesActiveColumns.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
+ Coverage   45.50%   45.75%   +0.25%     
==========================================
  Files        1044     1042       -2     
  Lines       17353    17214     -139     
  Branches     3149     3120      -29     
==========================================
- Hits         7897     7877      -20     
+ Misses       9456     9337     -119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… anything

… filter popover

…by rootOnly

…FilteringModel-pattern

graduta · 2026-04-16T13:44:54Z

+         * @param {FilteringModel} logOverviewModel.filteringModel filtering model
+         * @return {Component} the filter component
+         */
+        filter: ({ filteringModel }) => rawTextFilter(


What about re-using the runNumbersFilter in this case?

I don't see much use in making or using individual components for each filter that uses rawTextFilter that are virtually Identical.

What I do think is a good idea now that you mention it is to make a new component that would cover most of these usecases and change it for special cases such as authorFilter. Something like

export const textInputFilter = (filteringModel, key, placeholder) => rawTextFilter(filteringModel.get(key), { classes: ['w-100', `key-${filter}`], placeholder });

Which would then shorten these filter creations to:

filter: ({ filteringModel }) => textInputFilter(filteringModel, 'runNumbers', 'e.g. 553203, 553221, ...'),

graduta · 2026-04-16T13:46:08Z

+         * @return {Component} the filter component
+         */
+        filter: ({ filteringModel }) => rawTextFilter(
+            filteringModel.get('environmentIds'),


Similar question, I see that runsActiveColumns also has the environmentIds as rawtextFilter
Could we perhaps extract as a reusable component similar to runNumbersFilter?

graduta · 2026-04-16T13:46:20Z

+         * @param {FilteringModel} logOverviewModel.filteringModel filtering model
+         * @return {Component} the filter component
+         */
+        filter: ({ filteringModel }) => rawTextFilter(


…lumns

graduta · 2026-04-16T17:59:40Z

-import { fillNumberFilter } from '../../../components/Filters/LhcFillsFilter/fillNumberFilter.js';
 import { durationFilter } from '../../../components/Filters/LhcFillsFilter/durationFilter.js';
 import { beamTypeFilter } from '../../../components/Filters/LhcFillsFilter/beamTypeFilter.js';
-import { schemeNameFilter } from '../../../components/Filters/LhcFillsFilter/schemeNameFilter.js';


Should this file not be removed the same as runNumbersFilter? I do not see it being used anywhere else

graduta · 2026-04-16T17:59:58Z

 import { formatBeamType } from '../../../utilities/formatting/formatBeamType.js';
 import { frontLink } from '../../../components/common/navigation/frontLink.js';
 import { toggleStableBeamOnlyFilter } from '../../../components/Filters/LhcFillsFilter/stableBeamFilter.js';
-import { fillNumberFilter } from '../../../components/Filters/LhcFillsFilter/fillNumberFilter.js';


Should this file not be removed?

graduta · 2026-04-16T18:00:29Z

 import { iconCommentSquare, iconPaperclip } from '/js/src/icons.js';

 import { authorFilter } from '../../../components/Filters/LogsFilter/author/authorFilter.js';
-import createdFilter from '../../../components/Filters/LogsFilter/created.js';


Should be removed?

graduta · 2026-04-16T18:01:50Z


 import { authorFilter } from '../../../components/Filters/LogsFilter/author/authorFilter.js';
-import createdFilter from '../../../components/Filters/LogsFilter/created.js';
-import runsFilter from '../../../components/Filters/LogsFilter/runs.js';


Should be removed?

graduta · 2026-04-16T18:02:16Z

 import { formatRunsList } from '../../Runs/format/formatRunsList.js';
 import { profiles } from '../../../components/common/table/profiles.js';
-import { textFilter } from '../../../components/Filters/common/filters/textFilter.js';
-import { environmentFilter } from '../../../components/Filters/LogsFilter/environments.js';


graduta · 2026-04-16T18:02:28Z

-import { textFilter } from '../../../components/Filters/common/filters/textFilter.js';
-import { environmentFilter } from '../../../components/Filters/LogsFilter/environments.js';
 import { formatLhcFillsList } from '../../LhcFills/format/formatLhcFillsList.js';
-import { lhcFillsFilter } from '../../../components/Filters/LogsFilter/lhcFill.js';


Guust added 4 commits February 20, 2026 10:23

chore: remove redundant model assignment.

722caf7

chore: move all filters denoted as so to a filteringModel

f161cae

Make filterInputModel extend filterModel

9faffaf

rename inputfilter to ParsedInputFilter

247943b

NarrowsProjects self-assigned this Feb 20, 2026

NarrowsProjects requested a review from graduta as a code owner February 20, 2026 11:53

NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Feb 20, 2026

NarrowsProjects marked this pull request as draft February 20, 2026 11:53

implement authorfilter with ParsedInputFilterModel changes

114285d

NarrowsProjects force-pushed the improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern branch from 07567e2 to 114285d Compare February 20, 2026 12:02

Guust added 9 commits February 20, 2026 13:18

re-implement filter

f39f7ae

add tag-filters to the filtering object

df1fea3

replace titleFilter and contentFilter with RawTextFilterModels

96ca85f

make Authorfilter an implementation of RawTextFilterModel

93b3291

add runs filter to the filteringmodel

5a5e830

add environments filter to the filteringmodel

b5e7148

add lhcFills filter to the filteringmodel

3507ba0

add created filter to the filteringmodel

9c63409

move the sort 'filter' to fetchlogs, since it doesn't actually filter…

5500b3e

… anything

NarrowsProjects force-pushed the improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern branch from a936a03 to 5500b3e Compare February 20, 2026 16:24

Guust added 7 commits February 21, 2026 16:57

change filter to rawTextFilter for title

a09ae8b

fix test by changing event type to 'change'

512999b

fix content and author tests

0f15812

import openFilteringPanel and resetFilters

7b641ca

fix createdAt filter test

5ab8218

change event types to change

4c96d73

fix isAnyFilterActive

18ce4dc

NarrowsProjects marked this pull request as ready for review February 21, 2026 18:22

isaachilly requested changes Apr 13, 2026

View reviewed changes

NarrowsProjects added 2 commits April 13, 2026 18:25

make overview test more efficient with beforeEach

7731fd3

test: remove unneeded OpenFilterPanel calls

3bf7e66

NarrowsProjects requested a review from isaachilly April 14, 2026 07:17

NarrowsProjects added 2 commits April 14, 2026 09:22

remove takescreenshot

906674f

Remove unneeded javadoc params

a760812

isaachilly reviewed Apr 14, 2026

View reviewed changes

Comment thread lib/public/views/Logs/ActiveColumns/logsActiveColumns.js Outdated

chore: change the with margins to roughly span the filters the entire…

3addfc7

… filter popover

isaachilly reviewed Apr 14, 2026

View reviewed changes

Comment thread test/api/logs.test.js

isaachilly requested changes Apr 14, 2026

View reviewed changes

isaachilly reviewed Apr 14, 2026

View reviewed changes

Comment thread lib/public/components/Filters/LogsFilter/author/authorFilter.js Outdated

NarrowsProjects added 3 commits April 14, 2026 15:56

test: add happy-flow rootOnly test

85b9473

test: add log sorting tests for runs and for envirionments

e711fe9

reduce the width of the author filter component

4fa1173

NarrowsProjects requested a review from isaachilly April 14, 2026 14:56

NarrowsProjects added 2 commits April 15, 2026 10:39

chore removed unneeded length checks from should successfully filter …

88db5d8

…by rootOnly

chore: remove the needless 'limit' part of the rootOnly logs test

da4caf5

isaachilly previously approved these changes Apr 15, 2026

View reviewed changes

Merge branch 'main' into improv/O2B-1534/Migrate-Log-Overview-to-use-…

c768ba5

…FilteringModel-pattern

graduta requested changes Apr 16, 2026

View reviewed changes

NarrowsProjects added 5 commits April 16, 2026 19:05

feat: create textInputFilter

39df769

chore: replace runNumbersFilter and rawTextFileters with logsActiveCo…

f095cce

…lumns

feat: add a width argument to textinputFIlter

6fec661

replace the rest of the rawTextFilters

e095876

update tests to function with the new textInput components

033ff35

NarrowsProjects dismissed isaachilly’s stale review via 033ff35 April 16, 2026 17:06

fix failing tests

a40f51f

NarrowsProjects force-pushed the improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern branch from a86e6a6 to a40f51f Compare April 16, 2026 17:24

NarrowsProjects requested a review from graduta April 16, 2026 17:36

graduta requested changes Apr 16, 2026

View reviewed changes

Conversation

NarrowsProjects commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I have a JIRA ticket

Uh oh!

codecov bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NarrowsProjects Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NarrowsProjects Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NarrowsProjects Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

NarrowsProjects commented Feb 20, 2026 •

edited

Loading

codecov bot commented Feb 20, 2026 •

edited

Loading

NarrowsProjects Apr 16, 2026 •

edited

Loading

NarrowsProjects Apr 16, 2026 •

edited

Loading

NarrowsProjects Apr 16, 2026 •

edited

Loading