[Common] Unnecessary multiplication & division removed#14754
Open
MaximVirta wants to merge 1 commit intoAliceO2Group:masterfrom
Open
[Common] Unnecessary multiplication & division removed#14754MaximVirta wants to merge 1 commit intoAliceO2Group:masterfrom
MaximVirta wants to merge 1 commit intoAliceO2Group:masterfrom
Conversation
github-actions
bot
changed the title
Collaborator
vkucera
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
Member
|
This is obviously ok within |R not so much so in |F. I assume however the resulting, possible, bit difference is not an issue? |
Collaborator
|
O2 linter results: ❌ 41 errors, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unnecessary complexity removed. The variable "nmode" was multiplied and divided within the same function call.