Skip to content

[ALICE3] Tag secondaries from otf decayer properly and add qa to otf tracker#17130

Merged
jesgum merged 5 commits into
AliceO2Group:masterfrom
jesgum:master
Jul 20, 2026
Merged

[ALICE3] Tag secondaries from otf decayer properly and add qa to otf tracker#17130
jesgum merged 5 commits into
AliceO2Group:masterfrom
jesgum:master

Conversation

@jesgum

@jesgum jesgum commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot changed the title Tag secondaries from otf decayer properly and add qa to otf tracker [ALICE3] Tag secondaries from otf decayer properly and add qa to otf tracker Jul 20, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 33 errors, ⚠️ 22 warnings, 🔕 0 disabled

Please consider the following formatting changes to AliceO2Group#17130
@jesgum
jesgum marked this pull request as ready for review July 20, 2026 10:19
@jesgum
jesgum marked this pull request as draft July 20, 2026 10:23
@jesgum
jesgum marked this pull request as ready for review July 20, 2026 10:27
@jesgum
jesgum enabled auto-merge (squash) July 20, 2026 10:27

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @jesgum.

@jesgum
jesgum merged commit e19fa37 into AliceO2Group:master Jul 20, 2026
12 of 16 checks passed
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 14d05e1 at 2026-07-20 12:48:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 130 errors and 8 warnings.'
Found 130 errors and 8 warnings.
++ [[ 130 -gt 0 ]]
++ cat /sw/BUILD/60cf363ce87ae6265b9098ae13882047faf67ac2/O2Physics-code-check/errors.txt
ALICE3/Core/OTFParticle.h:45:5: error: 'mPdgCode' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:46:5: error: 'mGlobalIndex' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:47:5: error: 'mCollisionId' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:48:5: error: 'mPx' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:49:5: error: 'mPy' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:50:5: error: 'mPz' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:51:5: error: 'mE' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:52:5: error: 'mVx' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:53:5: error: 'mVy' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:54:5: error: 'mVz' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:55:5: error: 'mVt' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:56:5: error: 'mFlag' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:57:5: error: 'mStatusCode' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:104:3: error: function 'pdgCode' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:105:3: error: function 'globalIndex' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:106:3: error: function 'collisionId' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:107:3: error: function 'isAlive' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:108:3: error: function 'isPrimary' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:109:3: error: function 'isFromMcParticles' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:110:3: error: function 'weight' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:115:3: error: function 'flags' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:116:3: error: function 'statusCode' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:117:3: error: function 'vx' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:118:3: error: function 'vy' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:119:3: error: function 'vz' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:120:3: error: function 'vt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:121:3: error: function 'px' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:122:3: error: function 'py' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:123:3: error: function 'pz' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:124:3: error: function 'e' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:125:3: error: function 'radius' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:126:3: error: function 'r' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:127:3: error: function 'pt' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:128:3: error: function 'p' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:129:3: error: function 'phi' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:130:3: error: function 'eta' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:137:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:141:3: error: function 'y' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:148:7: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:152:3: error: function 'getMotherIndexStart' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:153:3: error: function 'getMotherIndexStop' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
ALICE3/Core/OTFParticle.h:154:3: error: function 'getDaughterIndexStart' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants