Antalya 25.8 Backport of #93866 - Google cloud storage support for data lakes catalogs #1318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google cloud storage support for data lakes catalogs
mkmkme
added
antalya
backport
mkmkme
commented
Jan 16, 2026
| if (capitalize_first_letter(storage_type_str) == "S3a") | ||
| else if (capitalize_first_letter(storage_type_str) == "S3a" || storage_type_str == "oss" || storage_type_str == "gs") | ||
| { | ||
| fiu_do_on(DB::FailPoints::database_iceberg_gcs, |
Collaborator
Author
There was a problem hiding this comment.
This particular bit I don't really like. It's there only for the sake of the integration test. But I've left it intact to be more aligned with the upstream.
Collaborator
There was a problem hiding this comment.
Better & easier to keep it consistent 👍
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google cloud storage support for data lakes catalogs (fixes #1199)
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Google cloud storage support for data lakes (ClickHouse#93866 by @scanhex12)
CI/CD Options
Exclude tests:
Regression jobs to run: