Antalya 26:6 Fix alter operations for iceberg

src/Common/FailPoint.cpp

@@ -163,6 +163,8 @@ static struct InitFiu
     ONCE(write_file_operation_fail_on_read) \
     REGULAR(slowdown_parallel_replicas_local_plan_read) \
     ONCE(iceberg_writes_cleanup) \
+    ONCE(iceberg_alter_catalog_update_schema_fail) \
+    ONCE(iceberg_alter_catalog_commit_reported_as_failed) \
     REGULAR(storage_cluster_read_sleep) \
     ONCE(backup_add_empty_memory_table) \
     PAUSEABLE_ONCE(backup_pause_on_start) \

src/Databases/DataLake/GlueCatalog.cpp

@@ -679,7 +679,9 @@ bool GlueCatalog::updateSchema(
     const String & table_name,
     const String & new_metadata_path,
     Poco::JSON::Object::Ptr /*new_schema*/,
-    Int32 /*previous_schema_id*/) const
+    Int32 /*previous_schema_id*/,
+    Int32 /*new_last_column_id*/,
+    Poco::JSON::Object::Ptr /*metadata*/) const
 {
     return updateMetadata(namespace_name, table_name, new_metadata_path, nullptr);
 }

src/Databases/DataLake/GlueCatalog.h

@@ -73,7 +73,9 @@ class GlueCatalog final : public ICatalog, private DB::WithContext
         const String & table_name,
         const String & new_metadata_path,
         Poco::JSON::Object::Ptr new_schema,
-        Int32 previous_schema_id) const override;
+        Int32 previous_schema_id,
+        Int32 new_last_column_id,
+        Poco::JSON::Object::Ptr metadata = nullptr) const override;
 
     void dropTable(const String & namespace_name, const String & table_name) const override;
 

src/Databases/DataLake/ICatalog.cpp

@@ -325,7 +325,9 @@ bool ICatalog::updateSchema(
     const String & /*table_name*/,
     const String & /*new_metadata_path*/,
     Poco::JSON::Object::Ptr /*new_schema*/,
-    Int32 /*previous_schema_id*/) const
+    Int32 /*previous_schema_id*/,
+    Int32 /*new_last_column_id*/,
+    Poco::JSON::Object::Ptr /*metadata*/) const
 {
     throw DB::Exception(DB::ErrorCodes::NOT_IMPLEMENTED, "updateSchema is not implemented");
 }

src/Databases/DataLake/ICatalog.h

@@ -196,7 +196,9 @@ class ICatalog
         const String & table_name,
         const String & new_metadata_path,
         Poco::JSON::Object::Ptr new_schema,
-        Int32 previous_schema_id) const;
+        Int32 previous_schema_id,
+        Int32 new_last_column_id,
+        Poco::JSON::Object::Ptr metadata = nullptr) const;
 
     /// Drop table from catalog.
     virtual void dropTable(const String & namespace_name, const String & table_name) const;