Skip to content

Iceberg deletion vector support (attempt #2) - #2183

Open
ianton-ru wants to merge 38 commits into
antalya-26.6from
feature/antalya-26.6/iceberg-puffin-deletion-vectors-read-2
Open

Iceberg deletion vector support (attempt #2)#2183
ianton-ru wants to merge 38 commits into
antalya-26.6from
feature/antalya-26.6/iceberg-puffin-deletion-vectors-read-2

Honor puffin_files_cache_size for the footer memo.

5a80deb
Select commit
Loading
Failed to load commit list.
DCO-2 / DCO required action Aug 13, 2026 in 1s

Check failed

There is one commit incorrectly signed off, the check did not pass.

Summary


Sha Message Pass or fail reason
🟢 13f4abe Merge branch 'master' into iceberg-puffin-deletion... Skipped: sign-off not required for members
🟢 9b31333 Fix build Skipped: sign-off not required for members
🟢 088cf75 Fix Iceberg trivial count to sum required record_c... Skipped: sign-off not required for members
🟢 69ab136 Remove isEtagUsableAsCacheKey, this method useless... Skipped: sign-off not required for members
🟢 0924819 Fix settings history Skipped: sign-off not required for members
🟢 88ea25b Merge branch 'antalya-26.6' into feature/antalya-2... Skipped: sign-off not required in merge commit
🟢 13a7278 Reuse the Puffin format reader instead of a sepa... Skipped: sign-off not required for members
🟢 1a9caaa Restore PuffinFilesRead accounting on seekable f... Skipped: sign-off not required for members
🟢 85cac8e Reject Iceberg DELETE/UPDATE when the snapshot has... Skipped: sign-off not required for members
🟢 9d396ae Cap non-seekable Puffin buffering with the absolut... Skipped: sign-off not required for members
🟢 3d7645f Validate SQL Puffin roaring bitmaps after readSafe... Skipped: sign-off not required for members
🟢 955b6a5 Fail closed trivial Iceberg count on cross-manifes... Skipped: sign-off not required for members
🟢 45b383e Treat zero-sized Puffin cache like use_puffin_file... Skipped: sign-off not required for members
🟢 da13047 Fix puffin_files_cache_max_entries docs: zero mean... Skipped: sign-off not required for members
🟢 ee53ef0 Fix version in settings history Skipped: sign-off not required for members
🟢 1036173 Fix SYSTEM DROP PUFFIN FILES CACHE privilege alias... Skipped: sign-off not required for members
🟢 83b40a9 Count PuffinFilesRead on SQL deletion-vector blob ... Skipped: sign-off not required for members
🟢 0da72d1 Tolerate Parquet FileMetaData.num_rows mismatch in... Skipped: sign-off not required for members
🟢 9929d10 Clarify PositionDeleteKindPresence is not used by ... Skipped: sign-off not required for members
🟢 64fd335 Remove dead empty-etag fallback after Puffin cache... Skipped: sign-off not required for members
🟢 4289367 Make Puffin cache waiter metrics gtest determinist... Skipped: sign-off not required for members
🟢 dbc6e40 Move ClusterFunctionReadTaskResponse protocol test... Skipped: sign-off not required for members
🟢 20bb262 Fail closed when schema_transform cannot be sent o... Skipped: sign-off not required for members
🟢 43d86a3 Allow mixed blob types in Puffin footers for delet... Skipped: sign-off not required for members
🟢 5aceb8c Include object-storage description in Puffin cache... Skipped: sign-off not required for members
🟢 1095d34 Fail closed when iceberg_info cannot be sent on ol... Skipped: sign-off not required for members
🟢 7c74abc Reject deletion-vector-v1 blobs unless snapshot an... Skipped: sign-off not required for members
🟢 a5867ff Do not cache count-from-files results under row fi... Skipped: sign-off not required for members
🟢 d275f3e Reject oversized Puffin DV cardinality before blob... Skipped: sign-off not required for members
🟢 c425bd2 Fix use_puffin_files_cache settings history previo... Skipped: sign-off not required for members
🟢 3be5b0c Merge branch 'antalya-26.6' into feature/antalya-2... Skipped: sign-off not required in merge commit
🔴 c04e775 fix(Parsers): extend magic_enum range for ASTSyste... Sign-off not found
🟢 ecf1a5c Reject Iceberg DELETE/UPDATE mutations on format v... Skipped: sign-off not required for members
🟢 f73c24a Allow need_only_count for Iceberg deletion vectors... Skipped: sign-off not required for members
🟢 a930aba Cache parsed Puffin footers by storage identity, p... Skipped: sign-off not required for members
🟢 e4a00de Charge Puffin cache keys and cell overhead in entr... Skipped: sign-off not required for members
🟢 f01a2d2 Simplify Puffin footer sharing to a small in-cache... Skipped: sign-off not required for members
🟢 5a80deb Honor puffin_files_cache_size for the footer memo. Skipped: sign-off not required for members

Errors details

Sign-off not found

No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.

To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

How to fix missing or invalid sign-offs

Option 1: add remediation commit

Option 2: fix commits without sign-off

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

Warning

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~38 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin feature/antalya-26.6/iceberg-puffin-deletion-vectors-read-2