Write machine-readable list output to os.Stdout in a single write - #1501
Merged
Conversation
PrintBackup routed every format through a tabwriter over os.Stdout. tabwriter auto-flushes lines that contain no tabs, but emits the payload and its terminating newline as two separate Write calls. Since zerolog logs to stderr, a log line can land between them whenever both streams are merged - e.g. `docker exec`, where the daemon reads the container's stdout and stderr from separate pipes with no ordering guarantee. The result is a spliced line, `...}]2026-08-11 18:29:25 INF ...`, which made `list remote --format=json` unparseable and flaked TestRebaseFTP with "invalid character '2' after top-level value". json/yaml/csv/tsv now write straight to os.Stdout in one Fprintln, so the payload and its newline reach the pipe as a single write. This also removes an inconsistency: those branches never called w.Flush() and worked only by way of tabwriter's implicit single-cell flush. tabwriter stays in the "text" branch, the only one that needs column alignment.
…ix_list_json_stdout_splice
Coverage Report for CI Build 31726025878Coverage at 69.241% (no base build to compare)Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrintBackup routed every format through a tabwriter over os.Stdout. tabwriter auto-flushes lines that contain no tabs, but emits the payload and its terminating newline as two separate Write calls. Since zerolog logs to stderr, a log line can land between them whenever both streams are merged - e.g.
docker exec, where the daemon reads the container's stdout and stderr from separate pipes with no ordering guarantee. The result is a spliced line,...}]2026-08-11 18:29:25 INF ..., which madelist remote --format=jsonunparseable and flaked TestRebaseFTP with "invalid character '2' after top-level value".json/yaml/csv/tsv now write straight to os.Stdout in one Fprintln, so the payload and its newline reach the pipe as a single write. This also removes an inconsistency: those branches never called w.Flush() and worked only by way of tabwriter's implicit single-cell flush. tabwriter stays in the "text" branch, the only one that needs column alignment.