Test: SquashFS required (clear error), check names of data/ files (error-filename) - #3929
Merged
Merged
Conversation
…s supported) The test took the last mount with "tmp" in it as the AppImage's contents. When the mount failed, e.g. for a DwarFS AppImage (#3868), that was an unrelated mount such as /run/snapd/ns, and the test reported "AppRun is missing" there. Now it waits for the mount of this AppImage, and if none appears it prints the runtime's message and "ERROR: Could not mount the AppImage..."; new label error-not-squashfs with a hint. The runtime's output goes to a file (it must not hold on to stdout) instead of /dev/null, so its message is no longer lost. README: an AppImage must use SquashFS; DwarFS etc. are not supported yet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
code/check-name.sh, with rules derived from the ~1700 existing names: - errors for files a PR adds (warnings for existing entries, which may have older names): blanks; the name of an AppImage file (.AppImage, architecture); "AppImage" or "Linux" unless part of the application's name in its desktop file; file extensions (.md, .txt, ...); an existing entry with the same name in different capitalization - warnings: version numbers (numbers can be part of names, e.g. Play_2048), unusual characters (EiskaltDC++, fre:ac), a name that does not match the application's name, "Linux" in the AppImage's file name Of the existing names, 22 would fail (all genuine: 7 case duplicates, 5 file extensions, AppImage file names) and 13 get warnings. The remarks are shown in the PR comment (only lines of the known form); new label error-filename; README lists the rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
…mber Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SquashFS only (error-not-squashfs)
/run/snapd/ns), and the test reported "AppRun is missing" there. It now waits for the mount of this AppImage, and if none appears, it prints the runtime's own message andERROR: Could not mount the AppImage…. This gets the new labelerror-not-squashfsand a hint./dev/null, so its message is not lost.Names of files in data/ (error-filename)
code/check-name.shhas rules derived from the ~1700 existing names. They are errors for files a PR adds, and warnings for existing entries, which may have older names:_).AppImage,x86_64,amd64, …).md,.txt,.yml, …)Play_2048)EiskaltDC++,fre:ac)GIMP)digikam/digiKam), 5 file extensions, AppImage file names. 13 would get warnings.error-filename; the README lists the rules.Tested
On a throwaway PR (#3928, closed):
ERROR: Could not mount the AppImage…;data/Jorvik-linux-x86_64→ fails before downloading;data/Jorvik→ passes, with no remarks.Locally:
check-name.shon all existing names and on sample cases; shellcheck and actionlint are clean.Hints, labels and the Names block in the comment take effect after merging (the publish workflow runs from
master). The labelserror-not-squashfsanderror-filenamealready exist.🤖 Generated with Claude Code
https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
Generated by Claude Code