Domains whitelist and blacklist #80
Open
+114
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hello, @sudharsan-selvaraj: could you please review our PR ? One of my colleague is working on the next one because the "Upstream proxy update" previously done by another contributor break the proxy in some case (during deleteSession and/or onUnexpectedShutdown). He's still investigate it and trying to fix it properly so he will give more details when he will be ready. Best regards, |
Contributor
|
Hello, @sudharsan-selvaraj, Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New suggestion of evolution:
whitelisteddomains: only the calls for those domains got through the proxy.blacklisteddomains: all the calls go through the proxy, except the one from the domains providedWith this change, it's possible to limit the usage of the proxy to the domain where the certificate is valid and avoid SSL/Certificate issue with the other calls.