-
Notifications
You must be signed in to change notification settings - Fork 14
Normalize integration card categories to match routes #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2cb71c6
Share normalizeCategory across cards, routes, and sidebar.
jottakka 964f078
Prefer JSON docsLink and store normalized categories.
jottakka f0f3a8d
Align empty JSON metadata with route resolution.
jottakka 99ec991
Retrigger CI after type widen for others category.
jottakka 5b344c8
Do not treat /others integration URLs as clickable pages.
jottakka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /** | ||
| * Shared integration category allow-list and normalization. | ||
| * | ||
| * Kept free of Node/fs imports so client components (integration cards) and | ||
| * server route helpers can share one contract without pulling server-only code | ||
| * into the browser bundle. | ||
| */ | ||
|
|
||
| export const INTEGRATION_CATEGORIES = [ | ||
| "productivity", | ||
| "social", | ||
| "entertainment", | ||
| "development", | ||
| "payments", | ||
| "search", | ||
| "sales", | ||
| "databases", | ||
| "customer-support", | ||
| "others", | ||
| ] as const; | ||
|
|
||
| export type IntegrationCategory = (typeof INTEGRATION_CATEGORIES)[number]; | ||
|
|
||
| /** | ||
| * Categories that have a real `app/.../integrations/<category>/[toolkitId]` | ||
| * route. `"others"` remains in `INTEGRATION_CATEGORIES` as the normalize | ||
| * fallback for stable card identity, but `next.config.ts` redirects | ||
| * `/integrations/others/*` to the index — so it is never clickable. | ||
| */ | ||
| export const ROUTABLE_INTEGRATION_CATEGORIES = INTEGRATION_CATEGORIES.filter( | ||
| (category): category is Exclude<IntegrationCategory, "others"> => | ||
| category !== "others" | ||
| ); | ||
|
|
||
| export function isRoutableIntegrationCategory( | ||
| category: string | ||
| ): category is Exclude<IntegrationCategory, "others"> { | ||
| return (ROUTABLE_INTEGRATION_CATEGORIES as readonly string[]).includes( | ||
| category | ||
| ); | ||
| } | ||
|
|
||
| export function normalizeCategory( | ||
| value: string | null | undefined | ||
| ): IntegrationCategory { | ||
| if (!value) { | ||
| return "others"; | ||
| } | ||
|
|
||
| return INTEGRATION_CATEGORIES.includes(value as IntegrationCategory) | ||
| ? (value as IntegrationCategory) | ||
| : "others"; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.