Skip to content

Conversation

@frbee
Copy link

@frbee frbee commented Oct 25, 2025

Questions

Describe your pull request

fix: fix for ShowCopilotButton in disable-copilot
fix: fix for MouseHoverTime

fix: fix encoding for '-'
fix: update registry value type
fix: remove duplicate arguments

feat: update appx

frbee added 2 commits October 25, 2025 23:28
fix: fix encoding for '-'
feat: update appx
fix: update registry value type
fix: remove duplicate arguments
@github-actions github-actions bot added the playbook Playbook related issues/PRs label Oct 25, 2025
- !appx: {name: 'Microsoft.WindowsMaps*', type: family}
- !appx: {name: 'Microsoft.WindowsSoundRecorder*', type: family}
- !appx: {name: 'Ink.Handwriting.Main.Store.en-US1.0', type: family}
- !appx: {name: 'Ink.Handwriting.Main.Store*', type: family}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@TheyCreeper TheyCreeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments on what should be changed and what works, changing the - in the command flags doesn't change anything.

@frbee frbee requested a review from TheyCreeper November 4, 2025 14:26
@frbee
Copy link
Author

frbee commented Nov 4, 2025

I added a few comments on what should be changed and what works, changing the - in the command flags doesn't change anything.

Actually, it doesn't work when I use non UTF8 (such as ASCII encoding) for editing

@TheyCreeper
Copy link
Member

UTF-8 and ASCII both have En Dash (–) and hyphens (-) in their tables, and both work when used as a paramter flag.

@TheyCreeper TheyCreeper closed this Nov 4, 2025
@Ast3risk-ops
Copy link

I added a few comments on what should be changed and what works, changing the - in the command flags doesn't change anything.

Actually, it doesn't work when I use non UTF8 (such as ASCII encoding) for editing

UTF-8 includes ASCII as a subset for backwards compatibility.

@frbee
Copy link
Author

frbee commented Nov 5, 2025

UTF-8 and ASCII both have En Dash (–) and hyphens (-) in their tables, and both work when used as a paramter flag.

I Known. Because I using Windows 10 cmd terminal, the default CHCP is 936, executing this cmd script will result in an error. So it's a bug? (Even if the script is saved using UTF-8 encoding)

@Ast3risk-ops
Copy link

UTF-8 and ASCII both have En Dash (–) and hyphens (-) in their tables, and both work when used as a paramter flag.

I Known. Because I using Windows 10 cmd terminal, the default CHCP is 936, executing this cmd script will result in an error. So it's a bug? (Even if the script is saved using UTF-8 encoding)

What? The scripts all work on win10.

@frbee
Copy link
Author

frbee commented Nov 5, 2025

UTF-8 and ASCII both have En Dash (–) and hyphens (-) in their tables, and both work when used as a paramter flag.

I Known. Because I using Windows 10 cmd terminal, the default CHCP is 936, executing this cmd script will result in an error. So it's a bug? (Even if the script is saved using UTF-8 encoding)

What? The scripts all work on win10.

When if /I not "%~2"=="/noAction" is true and the cmd default dhcp is 936, executing the statement powershell -command "stop-process -name explorer –force" will result in an error, + stop-process -name explorer 鈥揻orce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

playbook Playbook related issues/PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants