make local playbook build script more solid #1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make build steadier with strict mode runtime os checks and a timer cuz why not, run 7-zip quietly with exit code and tmp cleanup, create temp files only when needed, keep live log deps and oem behavior the same, clean all temps and avoid duplicate profile entries, .apbx output unchanged. also fixed the annoying "process cannot access the file because it is being used by another process" error
stop feeding p7zip with -spf flag so linux builds go through, without changing the playbook contents or behavior
Member
|
Sure, looks good to me. @Xyueta @RadNotRed what do you guys think |
RadNotRed
approved these changes
Nov 3, 2025
Member
|
will wait for @Xyueta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions
Describe your pull request
fix 7zip error handling and temp file cleanup, only stage files when needed, and make the script more solid lol
i was getting vietnam flashbacks from the "process cannot access the file because it is being used by another process" error
it now works perfectly on linux as well
this time im not gonna change another 500file