refactor: address rollup circuit audit comments #20077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

LeilaWang wants to merge 1 commit into next from lw/rollup_circuit_refactor

Contributor

LeilaWang commented Jan 30, 2026 •

edited

Loading

Fix incorrect error message
Rename copy_items_into_array to splice_at_count and simplify it

Other changes not from the audit

Use splice_at_count for merging non-revertible/revertible log arrays
Remove the confusing and more expensive array_merge


          Rollup circuit refactor.

736f3c8

LeilaWang force-pushed the lw/rollup_circuit_refactor branch from e86f591 to 736f3c8 Compare

January 30, 2026 17:02

LeilaWang requested a review from iAmMichaelConnor

February 2, 2026 10:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet