feat: re-land barretenberg-rs download functionality with fixes#20128
Merged
johnathan79717 merged 1 commit intomerge-train/barretenbergfrom Feb 3, 2026
Merged
Conversation
johnathan79717
force-pushed
the
jh/reland-barretenberg-rs-download
branch
from
7915627 to
ce78465
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
ludamad
approved these changes
Feb 3, 2026
ludamad
reviewed
Feb 3, 2026
| @@ -0,0 +1,4801 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| pragma solidity ^0.8.27; | |||
Re-lands the download functionality from #20105 with the following fixes: - Check for all 0.x.x development versions, not just 0.0.1 - Set BB_LIB_DIR in build function (ffi feature is on by default) The build.rs now properly detects development versions and requires either BARRETENBERG_VERSION to be set to a released version, or BB_LIB_DIR to point to a local build.
johnathan79717
force-pushed
the
jh/reland-barretenberg-rs-download
branch
from
ce78465 to
4085492
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 3, 2026
BEGIN_COMMIT_OVERRIDE cherchore: graph tooling audit 0 (#19691) chore: opt sol scope renaming (#20123) feat: add download functionality to barretenberg-rs build.rs (#20105) fix: set BB_LIB_DIR in build function (ffi feature is on by default) Revert barretenberg-rs download functionality feat: re-land barretenberg-rs download functionality with fixes (#20128) fix: skip FFI feature in PipeBackend tests fix: skip FFI feature in PipeBackend tests END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands the download functionality from #20105 with the following fixes:
The build.rs now properly detects development versions and requires either
BARRETENBERG_VERSION to be set to a released version, or BB_LIB_DIR to
point to a local build.
Test plan