[NetAppFiles] pool size enhancement, examples, and default networkfeture#33387
[NetAppFiles] pool size enhancement, examples, and default networkfeture#33387audunn wants to merge 3 commits into
Conversation
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
This PR updates the NetApp Files command module to support more flexible capacity pool sizing (including a bytes-based size parameter with mutual exclusivity), expands scenario coverage around pool sizing and CMK volume creation, and changes the default --network-features for volume creation to Standard. It also updates the account create help examples to clarify quoting for CMK + user-assigned identity scenarios across shells.
Changes:
- Add
--size-in-bytesforaz netappfiles pool create/updateand enforce--sizevs--size-in-bytesmutual exclusivity; validate/convert sizes to bytes and append an AFEC registration hint on relevant service errors. - Add/extend scenario tests and recordings for pool sizing defaults and
--size-in-bytes, plus an end-to-end CMK volume create flow. - Change
az netappfiles volume create --network-featuresdefault fromBasictoStandard, and refineaccount createCMK examples.
Reviewed changes
Copilot reviewed 12 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/netappfiles/custom.py |
Implements pool size argument reshaping/validation and AFEC hinting logic for sub-1-TiB pool size failures. |
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_pool_commands.py |
Adds scenario coverage for pool creation without --size, and for --size-in-bytes (with AFEC hint expectation); includes a skipped 0.5 TiB scenario. |
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/test_volume_commands.py |
Adds an end-to-end CMK volume create scenario including private endpoint setup. |
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_pool_parameters.yaml |
Updates test recording to reflect new CLI version/requests. |
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_get_pool_by_name.yaml |
Updates test recording to reflect new CLI version/requests. |
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_string_size.yaml |
Updates test recording to reflect new CLI version/requests. |
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_size_in_bytes.yaml |
Adds recording for the new --size-in-bytes scenario. |
src/azure-cli/azure/cli/command_modules/netappfiles/tests/latest/recordings/test_create_pool_nosize.yaml |
Adds recording for the new “no size provided (default applied)” scenario. |
src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/volume/_create.py |
Changes the default for --network-features to Standard. |
src/azure-cli/azure/cli/command_modules/netappfiles/aaz/latest/netappfiles/account/_create.py |
Updates the account create CMK examples for bash/zsh and PowerShell quoting. |
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/netappfiles/custom.py:311
- The
--sizehelp text says the value must be an integer TiB “in multiples of 4”, but_resolve_pool_size_bytesvalidates “0.5 or any positive integer number of TiB” (and the PR description says integer multiples of 1 TiB). Please align the--sizehelp text with the actual validation/behavior to avoid misleading users.
args_schema.size_tib = AAZFloatArg(
options=["--size"],
arg_group="Properties",
help="Provisioned size of the pool. Must be an integer number of tebibytes in multiples of 4. "
"Use either --size or --size-in-bytes, not both.",
nullable=on_update,
fmt=AAZFloatArgFormat(minimum=0.5),
)
src/azure-cli/azure/cli/command_modules/netappfiles/custom.py:318
- The
--size-in-byteshelp text states values must be in 1 TiB chunks only, but_resolve_pool_size_bytesalso allows 549755813888 bytes (512 GiB). Please update the help text to include the 512 GiB exception (or adjust validation if 512 GiB should not be accepted).
args_schema.size_in_bytes = AAZIntArg(
options=["--size-in-bytes"],
arg_group="Properties",
help="Provisioned size of the pool (in bytes). Allowed values are in 1TiB chunks (value must be multiple of 1099511627776). "
"Use either --size or --size-in-bytes, not both.",
nullable=on_update,
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Related command
Description
Testing Guide
History Notes
[NetAppFiles]
az netappfiles pool create: Added new--size-in-bytesparameter accepting bytes directly (549755813888for 512 GiB or any positive multiple of1099511627776for 1 TiB).--sizeand--size-in-bytesare mutually exclusive.[NetAppFiles]
az netappfiles pool update: Added new--size-in-bytesparameter accepting bytes directly (549755813888for 512 GiB or any positive multiple of1099511627776for 1 TiB).--sizeand--size-in-bytesare mutually exclusive.[NetAppFiles]:
az netappfiles volume create: Parameter--network-featuresdefault value changed fromBasictoStandard.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.