Skip to content

Fixed issue #271 #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimHoogstrate merged 1 commit into from
Jun 5, 2025
Merged

Fixed issue #271 #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions geocoding_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 4.0.1

* Resolved issue #271 where the app could crash if the onError message was null. The error message is now properly handled as nullable.

## 4.0.0

* **BREAKING CHANGES** Please update to Flutter 3.29+ before updating to this version
Expand Down
12 changes: 6 additions & 6 deletions geocoding_android/android/src/main/java/com/baseflow/geocoding/MethodCallHandlerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,10 @@ public void onGeocode(List<Address> addresses) {
}

@Override
public void onError(String errorMessage) {
public void onError(@Nullable String errorMessage) {
result.error(
"IO_ERROR",
String.format(errorMessage),
errorMessage != null ? errorMessage : "Unknown error occurred",
null);
}
});
Expand Down Expand Up @@ -163,10 +163,10 @@ public void onGeocode(List<Address> addresses) {
}

@Override
public void onError(String errorMessage) {
public void onError(@Nullable String errorMessage) {
result.error(
"IO_ERROR",
String.format(errorMessage),
errorMessage != null ? errorMessage : "Unknown error occurred",
null);
}
});
Expand Down Expand Up @@ -198,10 +198,10 @@ public void onGeocode(List<Address> addresses) {
}

@Override
public void onError(String errorMessage) {
public void onError(@Nullable String errorMessage) {
result.error(
"IO_ERROR",
String.format(errorMessage),
errorMessage != null ? errorMessage : "Unknown error occurred",
null);
}
});
Expand Down
2 changes: 1 addition & 1 deletion geocoding_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: geocoding_android
description: A Flutter Geocoding plugin which provides easy geocoding and reverse-geocoding features.
version: 4.0.0
version: 4.0.1
repository: https://github.com/baseflow/flutter-geocoding/tree/main/geocoding_android
issue_tracker: https://github.com/Baseflow/flutter-geocoding/issues

Expand Down