Frontend revamp addaccount #3727
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed from add.tsx to be to a more descriptive filename. This is consistent with the react route and guide component.
Using the standard View component changes the layout to be more consistent with other workflows. This will change the layout on mobile, as the content and title are not vertically centered anymore.
Drop the white box around the add-account workflow to make it more consistent with the rest of the app. The white box is still used in a few different components. Other changes: Removed some custom styling and rewrote using standard components such as ViewHeader and ViewButtons. This has the nice side effect that the layout is more consistent with other views. Changed to nicer looking animated checkmark icon in success step. Fixed minor layout jump between the steps in the workflow. Reason was the dropdown and input field had slightly different height and margin.
Added UseBackButton helper so users can go back 1 step within the
workflow when they are on the choose-account-name step.
Tested with
if(window.onBackButtonPressed()) { history.back() }
The backend api getSupportedCoins can sometimes take a moment to
respond, this can cause a brief flash of a warning message.
Added a new loading step to render skeleton and loading... text
while the component waits for getSupportedCoins.
Tested with small sleep helper function:
const sleep = async (ms: number) => new Promise(resolve => setTimeout(resolve, ms));
There is no reason to import all members of keystore and backend api modules.
thisconnect
force-pushed
the
frontend-revamp-addaccount
branch
from
b358542 to
178fd19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't update the Changelog, for the user this is just a minor layout change with no new features.