Skip to content

ci(scripts): decouple Docker Hub check from npm publish #8600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roshan-bitgo merged 1 commit into from
Apr 22, 2026
Merged

ci(scripts): decouple Docker Hub check from npm publish #8600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions .github/workflows/npmjs-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ jobs:
express-version: ${{ steps.compute-express-git-tag.outputs.version }}
express-git-tag: ${{ steps.compute-express-git-tag.outputs.git-tag }}
express-git-sha: ${{ steps.compute-express-git-sha.outputs.git-sha }}
express-docker-exists: ${{ steps.check-docker-image.outputs.express-docker-exists }}
steps:
- name: Checkout repository
uses: actions/checkout@v6
Expand Down Expand Up @@ -165,15 +166,25 @@ jobs:

- name: Check if Docker image already exists in Docker Hub
if: inputs.dry-run == false
id: check-docker-image
run: |
VERSION="${{ steps.compute-express-git-tag.outputs.version }}"

if curl -s -f "https://hub.docker.com/v2/repositories/bitgo/express/tags/$VERSION" > /dev/null; then
echo "::error::Docker image bitgo/express:$VERSION already exists in Docker Hub"
exit 1
echo "⚠️ Docker image bitgo/express:$VERSION already exists in Docker Hub — Docker publish will be skipped"
echo "express-docker-exists=true" >> "$GITHUB_OUTPUT"
else
echo "✅ Docker image bitgo/express:$VERSION does not exist in Docker Hub"
echo "express-docker-exists=false" >> "$GITHUB_OUTPUT"
fi

echo "✅ Docker image bitgo/express:$VERSION does not exist in Docker Hub"
- name: Summarise Docker image status
if: inputs.dry-run == false
run: |
if [ "${{ steps.check-docker-image.outputs.express-docker-exists }}" == "true" ]; then
echo "### ⚠️ Docker publish skipped" >> "$GITHUB_STEP_SUMMARY"
echo "Image \`bitgo/express:${{ steps.compute-express-git-tag.outputs.version }}\` already exists in Docker Hub." >> "$GITHUB_STEP_SUMMARY"
echo "The npm release will proceed normally." >> "$GITHUB_STEP_SUMMARY"
fi

- name: Update Express GitHub summary
if: inputs.dry-run == false
Expand Down Expand Up @@ -286,7 +297,7 @@ jobs:

publish-express-to-docker-hub:
name: Publish Express To Docker Hub
if: inputs.dry-run == false
if: inputs.dry-run == false && needs.get-release-context.outputs.express-docker-exists != 'true'
needs:
- get-release-context
- release-bitgojs
Expand Down
Loading