test(abstract-utxo): simplify prebuildAndSign test setup#8659
Merged
Conversation
Remove encrypted keychains and webauthn fixtures from prebuildAndSign tests. Use plain private keys directly instead of testing passphrase decryption logic. Move webauthn passphrase fallback tests to dedicated test file where they belong. Issue: BTC-0 Co-authored-by: llm-git <llm-git@ttll.de>
Remove the `txFormat` parameter from the `run` function and hardcode `nockOutputAddresses` to `false` since all tests now use PSBT format. Issue: BTC-0 Co-authored-by: llm-git <llm-git@ttll.de>
Update test to include replay protection pubkey configuration when creating transaction. Uses getReplayProtectionPubkeys helper to fetch appropriate key for coin network. Issue: BTC-0 Co-authored-by: llm-git <llm-git@ttll.de>
davidkaplanbitgo
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove encrypted keychains and webauthn fixtures from prebuildAndSign
tests. Use plain private keys directly instead of testing passphrase
decryption logic.
Move webauthn passphrase fallback tests to dedicated test file where
they belong.
Remove the
txFormatparameter from therunfunction and hardcodenockOutputAddressestofalsesince all tests now use PSBT format.Update test to include replay protection pubkey configuration when
creating transaction. Uses getReplayProtectionPubkeys helper to fetch
appropriate key for coin network.
Issue: BTC-0