Skip to content

feat(utxo-descriptors): add sBTC taproot descriptors#8706

Open
veetragjain wants to merge 1 commit intomasterfrom
veetragjain/cshld-744-create-utxo-descriptors-package-for-sbtc-taproot-descriptors
Open

feat(utxo-descriptors): add sBTC taproot descriptors#8706
veetragjain wants to merge 1 commit intomasterfrom
veetragjain/cshld-744-create-utxo-descriptors-package-for-sbtc-taproot-descriptors

Conversation

@veetragjain
Copy link
Copy Markdown
Contributor

Ticket: CSHLD-744

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 7, 2026

@veetragjain veetragjain force-pushed the veetragjain/cshld-744-create-utxo-descriptors-package-for-sbtc-taproot-descriptors branch from 90bd989 to 437b5cd Compare May 7, 2026 06:01
@veetragjain
Copy link
Copy Markdown
Contributor Author

@claude

@veetragjain veetragjain force-pushed the veetragjain/cshld-744-create-utxo-descriptors-package-for-sbtc-taproot-descriptors branch from 437b5cd to cceee87 Compare May 7, 2026 11:00
Comment thread modules/utxo-descriptors/package.json Outdated
Comment thread modules/utxo-descriptors/src/sbtc/depositAddress.ts Outdated
Comment thread modules/utxo-descriptors/src/sbtc/descriptor.ts Outdated
Comment thread modules/utxo-descriptors/test/unit/sbtc/descriptor.ts Outdated
Comment thread modules/utxo-descriptors/test/unit/sbtc/descriptor.ts Outdated
@veetragjain veetragjain force-pushed the veetragjain/cshld-744-create-utxo-descriptors-package-for-sbtc-taproot-descriptors branch from c457955 to 2d1f07e Compare May 8, 2026 10:40
Comment thread modules/utxo-descriptors/README.md Outdated
@veetragjain veetragjain force-pushed the veetragjain/cshld-744-create-utxo-descriptors-package-for-sbtc-taproot-descriptors branch from 2d1f07e to 37a7a06 Compare May 8, 2026 11:42
@@ -0,0 +1,65 @@
{
"name": "@bitgo/utxo-descriptors",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to set this to { private: true } for now, we need to publish this with a manual step first

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought someone from velocity team will help creating the package first based on this thread - https://bitgo.slack.com/archives/C010AEXLLCR/p1772034901293329

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but I think the sequence is: create package in repo with private: true, then manual publish, then we remove the private: true again

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure it's the reason why

[BitGo SDK / verify-npm-packages (pull_request)]

is failing

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's documented anywhere, but I don't see this being done for some of the recently added packages like sdk-coin-kaspa

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try setting it to private: true anyway so we can get a green build

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let me try it once.

@veetragjain veetragjain force-pushed the veetragjain/cshld-744-create-utxo-descriptors-package-for-sbtc-taproot-descriptors branch from 37a7a06 to 01a22f9 Compare May 8, 2026 12:14
@veetragjain veetragjain force-pushed the veetragjain/cshld-744-create-utxo-descriptors-package-for-sbtc-taproot-descriptors branch from 01a22f9 to 19dac58 Compare May 8, 2026 12:15
* as a Taproot internal key guarantees the output cannot be spent via the
* key path — only via one of the script-path leaves.
*/
export const UNSPENDABLE_INTERNAL_KEY = '50929b74c1a04954b78b4b6035e97a5e078a5a0f28ec96d547bfee9ace803ac0';
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linear add a ticket so we expose this from wasm-utxo where we define it already I believe

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue T1-3296

@veetragjain veetragjain marked this pull request as ready for review May 8, 2026 12:37
@veetragjain veetragjain requested review from a team as code owners May 8, 2026 12:37
@veetragjain veetragjain requested review from bdesoky and ranga-r2 May 8, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants