Skip to content

Fix ImportError from private typing module members in Python 3.8 #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix ImportError from private typing module members in Python 3.8 #661

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0645e2a
Initial plan
Copilot Jan 22, 2026
bd1b2ac
Fix ImportError by replacing private typing members with public API
Copilot Jan 22, 2026
d5a0ad9
Update src/math_spec_mapping/Load/type.py
rororowyourboat Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/math_spec_mapping/Load/type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from .general import check_json_keys
from ..Classes import Type
import os
from typing import _UnionGenericAlias, List, _GenericAlias
from typing import List, get_origin
Comment thread
rororowyourboat marked this conversation as resolved.
Outdated


def convert_type(data, ms):
Expand Down Expand Up @@ -34,9 +34,8 @@ def convert_type(data, ms):
val = val.__name__
out[key] = val
data["type_name"]["python"] = str(out)
elif type(data["type"]["python"]) == _UnionGenericAlias:
data["type_name"]["python"] = data["type"]["python"].__repr__()
elif type(data["type"]["python"]) == _GenericAlias:
elif get_origin(data["type"]["python"]) is not None:
# Handle generic types (Union, List, etc.)
data["type_name"]["python"] = data["type"]["python"].__repr__()
else:
data["type_name"]["python"] = data["type"]["python"].__name__
Expand Down
Loading