Conversation
|
Hi @aki-mizu good morning I send the image thanks |
|
@eduardocalfaia Battery display is not supported yet on T-Display-S3-Pro with camera, this pull request is to solve this issue. |
|
@aki-mizu but do you have a image not official to test? |
|
@eduardocalfaia |
|
@aki-mizu thanks it is working now. |
| .pin_sscb_scl = CONFIG_CAMERA_SCL, | ||
| .pin_sccb_sda = CONFIG_CAMERA_SCCB_EXISTING_I2C_PORT >= 0 ? -1 : CONFIG_CAMERA_SDA, | ||
| .pin_sccb_scl = CONFIG_CAMERA_SCCB_EXISTING_I2C_PORT >= 0 ? -1 : CONFIG_CAMERA_SCL, | ||
| .sccb_i2c_port = CONFIG_CAMERA_SCCB_EXISTING_I2C_PORT, |
There was a problem hiding this comment.
CONFIG_CAMERA_SCCB_EXISTING_I2C_PORT only seems to exist so you can set this here, so you might as well add an ifdef block on BOARD_TYPE_TTGO_TDISPLAYS3PROCAMERA instead, comment whats different for that board type here in this file and remove the added kconfig entry.
| #elif defined(CONFIG_BOARD_TYPE_WS_TOUCH_LCD2) | ||
| #include "power/wslcdtouch2.inc" | ||
| #elif defined(CONFIG_BOARD_TYPE_TTGO_TDISPLAYS3PROCAMERA) | ||
| // T-Display S3 Pro Camera has an SY6970 charger/power-path PMU. |
There was a problem hiding this comment.
Remove this comment, its obvious here that the included file is specific to the HW on the board.
| uint8_t vbus_status; | ||
| if (sy6970_get_vbus_status(&vbus_status) != ESP_OK) { | ||
| // A false negative could allow USB-host mode while external power is | ||
| // still connected, so fail closed when the PMU cannot be read. |
There was a problem hiding this comment.
This seems to be AI which loves the 'fail closed' verbage which is meaningless without further context.
Please rewrite this comment in human language, and if AI was used in the commit please note it in the commit description.
3 participants
Currently TTGO T-Display S3 Pro Camera model does not support battery display and always displays USB connection regardless if it's connect to USB or not.