Use anyhow::Error in place of String#130
Draft
canndrew wants to merge 2 commits intoBlockstreamResearch:masterfrom
Draft
Use anyhow::Error in place of String#130canndrew wants to merge 2 commits intoBlockstreamResearch:masterfrom
canndrew wants to merge 2 commits intoBlockstreamResearch:masterfrom
Conversation
Add clap as a dependency and use it to parse the command line arguments. Also add a --debug cli option to include debug symbols.
Use the anyhow crate for errors where we're currently just using String. This makes it easier to add context to errors and avoids the need to convert to a string when bubbling up errors. Also box the `Error` field in `RichError` to reduce its size and keep clippy happy.
Contributor
Author
|
I'll fix the changes on the library side to use a new error type rather than anyhow then re-open this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the anyhow crate for errors where we're currently just using String. This makes it easier to add context to errors and avoids the need to convert to a string when bubbling up errors.
Also box the
Errorfield inRichErrorto reduce its size and keep clippy happy.This PR builds off of #129.