Fix FFI type layout for Android#347
Open
KyrylR wants to merge 3 commits intoBlockstreamResearch:masterfrom
Open
Fix FFI type layout for Android#347KyrylR wants to merge 3 commits intoBlockstreamResearch:masterfrom
KyrylR wants to merge 3 commits intoBlockstreamResearch:masterfrom
Conversation
KyrylR
force-pushed
the
fix/ffi-layout
branch
9 times, most recently
from
690d491 to
0e0fada
Compare
Contributor
Author
|
I tried to test it in CI, but I wasn’t able to set up proper Android emulation, so I dropped this idea for now Though, it works on all tested iOS platforms, also manually tested on my Android phone |
Contributor
Author
|
Also added an ability to get misalignment, so if we face same issue again, it would be easier to debug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently my docker check was wrong: #334 (comment)
This time I launched in on Android and verified that it works