This repository was archived by the owner on Dec 2, 2020. It is now read-only.
Feature Enhancement: Supply current popUp index parameter for lineGraph#256
Open
xuzhiming wants to merge 5 commits intoBoris-Em:masterfrom
Open
Feature Enhancement: Supply current popUp index parameter for lineGraph#256xuzhiming wants to merge 5 commits intoBoris-Em:masterfrom
xuzhiming wants to merge 5 commits intoBoris-Em:masterfrom
Conversation
Classes/BEMSimpleLineGraphView.h
Outdated
| @param graph The graph object requesting the total number of points. | ||
| @return The suffix to append to the popup report. */ | ||
| - (NSString *)popUpSuffixForlineGraph:(BEMSimpleLineGraphView *)graph; | ||
| - (NSString *)popUpSuffixForlineGraph:(BEMSimpleLineGraphView *)graph index:(NSUInteger)index; |
Owner
There was a problem hiding this comment.
Please rename the method to - (NSString *)popUpSuffixForlineGraph:(BEMSimpleLineGraphView *)graph atIndex:(NSUInteger)index;.
The comment also needs to be updated.
Owner
|
Hi @xuzhiming, |
Author
|
ok, I'll address those issues soon. |
…popUpPrefixForlineGraph. remove awakeFromNib to avoid commonInit be called twice. use the longestString index for popUp.
Author
|
Hi @Boris-Em , please check the latest commit. |
Collaborator
|
This looks great! It is a breaking change. Could you deprecate the old methods? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supply current popUp index parameter for popUpSuffixForlineGraph and popUpPrefixForlineGraph
Feature Enhancement
This pull request enhance the following features:
Notes