Skip to content

update skill to say dont make up Tabler icons - #2703

Merged
emmacramer merged 5 commits into
mainfrom
emmacramer-patch-1
Aug 11, 2026
Merged

update skill to say dont make up Tabler icons#2703
emmacramer merged 5 commits into
mainfrom
emmacramer-patch-1

Conversation

@emmacramer

@emmacramer emmacramer commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

silly agent

@emmacramer
emmacramer requested a review from steve8708 August 6, 2026 20:28
@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@emmacramer
emmacramer requested a review from NKoech123 August 6, 2026 20:28
@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

@netlify

This comment has been minimized.

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

@emmacramer
emmacramer enabled auto-merge (squash) August 7, 2026 15:02
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Visual recap — skipped (diff too small)

The change in this pull request is too small to be worth a visual recap. This is informational only and does not block the PR.

builder-io-integration[bot]

This comment was marked as outdated.

@emmacramer

Copy link
Copy Markdown
Contributor Author

@builderio-bot why is the Chat template E2E test failing?

@builder-io-integration

Copy link
Copy Markdown
Contributor

I looked into PR #2703 and the CI run for the failing job.

What's failing: The Generate + run standalone Chat job fails inside pnpm qa:sign-in (scripts/qa-sign-in-matrix-smoke.ts), specifically a Playwright click on .tab[data-tab="signup"]:

Error: page.click: Timeout 30000ms exceeded.
- locator resolved to <button data-tab="signup" class="tab active" ...>Create account</button>
- element is not visible

The element exists (it's already marked active) but Playwright can't get it into a stable/visible state within 30s — a rendering/timing race in the sign-in test harness, not a missing element.

Why it's not related to this PR: This PR only touches .agents/skills/frontend-design/SKILL.md. There's no app code, template, or test change in the diff, so it can't be the cause of a browser-rendering timing issue in the sign-in smoke test.

Confirmation it's not a broken/consistently-failing test: The same workflow has been passing reliably on main in recent runs, so this looks like CI flakiness in this run (a slow/unstable render during the standalone Chat E2E) rather than a real regression.

Recommendation: Re-run the failed job — this should be safe to retry since the PR content is docs-only. Want me to trigger a re-run via gh run rerun --failed?



🟡 Diagnosed the failing Chat E2E job as an unrelated CI flake (docs-only PR); awaiting confirmation to re-run it.


Edit in Builder  Preview

builder-io-integration[bot]

This comment was marked as outdated.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

The latest PR head remains a documentation-only addition to .agents/skills/frontend-design/SKILL.md. The Tabler icon verification guidance is unchanged and remains technically correct: the declaration path is node_modules/@tabler/icons-react/dist/tabler-icons-react.d.ts, the package layout supports it, and the previously corrected dist/esm/ path has not regressed.

Independent reviews found no new or unresolved actionable issues. The guidance is consistent with the surrounding frontend-design rules and should help prevent invalid named imports that fail Vite builds. This remains low risk with no user-facing runtime impact. 🧪 Browser testing: Skipped — PR only modifies backend/config/docs, no UI impact.

@emmacramer
emmacramer merged commit 9227264 into main Aug 11, 2026
39 of 40 checks passed
@emmacramer
emmacramer deleted the emmacramer-patch-1 branch August 11, 2026 16:33
@netlify

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants