[pull] master from MusicPlayerDaemon:master - #111
Merged
Conversation
The three-argument form of "sticker delete" deletes all stickers of a URI and passes a null "name" to DomainHandler::Delete(). If the delete affects no rows, the error path formats that null pointer with libfmt, which aborts the process, so any client can terminate the daemon with sticker delete song "foo.ogg" on a song that has no stickers. Report the URI instead when no name was given.
When software volume is enabled (mixer_type "software"), the ReplayGainFilter converts S16 input to S24_P32 (PcmVolume::Open() with allow_convert=true) to avoid losing precision. FilterChunk() applied that filter to both chunks and then called pcm_mix() with in_audio_format.format (S16) on data that was already S24_P32. Mixing 32-bit samples as if they were 16-bit produces loud noise for the whole cross-fade duration. OpenFilter() already uses the ReplayGainFilter's output format for the rest of the filter chain; use it for the cross-fade mix as well. Fixes #2050, probably also #1101.
The PLS parser materializes up to 65,536 entries before returning any songs. Each entry can retain a file URI and title near the text line limit, allowing a playlist to consume hundreds of MiB. Add an InputStream proxy which enforces a byte limit and wrap PLS input with a 16 MiB budget. Known-size streams are rejected before parsing, while the read limit also covers streams whose size is not known in advance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )