Skip to content

#192 Made some typings optional#193

Open
Brqqq wants to merge 1 commit intoCatalystCode:masterfrom
Brqqq:typing-fix
Open

#192 Made some typings optional#193
Brqqq wants to merge 1 commit intoCatalystCode:masterfrom
Brqqq:typing-fix

Conversation

@Brqqq
Copy link

@Brqqq Brqqq commented May 14, 2021

@guidoprinc
Copy link

channelImportance type should be `number since it's value is a double

channelEnableLights: boolean;
channelEnableVibration: boolean;
channelName?: string;
channelImportance?: boolean;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
channelImportance?: boolean;
channelImportance?: number;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants