-
Notifications
You must be signed in to change notification settings - Fork 8
Add comprehensive test coverage for MCPConnectionPool connection lifecycle #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Co-authored-by: luv-bansal <[email protected]>
Co-authored-by: luv-bansal <[email protected]>
Co-authored-by: luv-bansal <[email protected]>
Copilot
AI
changed the title
[WIP] Update Agentic Class based on PR-1090 review
Add comprehensive test coverage for MCPConnectionPool connection lifecycle
Dec 15, 2025
Minimum allowed line rate is |
sainivedh
pushed a commit
that referenced
this pull request
Dec 23, 2025
* Initial plan * Bump version to 11.12.2 and update changelog Co-authored-by: mogith-pn <[email protected]> * Add all merged PRs to changelog since 11.12.1 Added 10 PRs merged after 11.12.1 release (2025-12-03): - Added: PRs #843, #856, #860, #875 - Changed: PR #870 - Fixed: PRs #858, #867, #868, #877, #879 All PRs include reference links per feedback. Co-authored-by: mogith-pn <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: mogith-pn <[email protected]>
luv-bansal
added a commit
that referenced
this pull request
Jan 9, 2026
* Agentic Class * reuse connection * reuse connection and make it optimise * simplify code * simplify code * increase idle time and verify duration * Fix co-pilot comments * co-pilot comments * co-pilot comments * Add comprehensive test coverage for MCPConnectionPool connection lifecycle (#875) * Initial plan * Add comprehensive test coverage for MCPConnectionPool Co-authored-by: luv-bansal <[email protected]> * Improve test robustness based on code review feedback Co-authored-by: luv-bansal <[email protected]> * Optimize test execution time and improve mock specifications Co-authored-by: luv-bansal <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: luv-bansal <[email protected]> * Fix co-pilot suggestions * Agentic Class tests * fix agentic class * MCP URL in model format * Fix tests --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
MCPConnectionPoolsingleton and its connection lifecycle management lacked test coverage for critical failure scenariosHow
Tests
Notes
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.