Fix Firebolt Q36-Q42 Parquet date filters - #1395
Open
vogelsgesang wants to merge 1 commit into
Open
Conversation
Firebolt's Q36–Q42 used incorrect epoch-day constants. * Firebolt filtered 16617..16647, meaning July 2015. * The dataset spans 15888..15917—July 2013. Therefore, Firebolt returns empty results, quickly via Parquet metadata pruning. Use the dataset's actual epoch-day ranges so Q36-Q42 process the intended July 2013 rows instead of returning empty results.
vogelsgesang
had a problem deploying
to
benchmark-approval
August 15, 2026 19:46 — with 
GitHub Actions
Error
GitHub Actions
Error
Contributor
Author
|
FYI @hall-alex @moshap-firebolt as previous contributors to the Firebolt setup |
Contributor
Thanks for the fix! |
alexey-milovidov
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firebolt's Q36–Q42 used incorrect epoch-day constants.
Therefore, Firebolt returned empty results quickly via Parquet metadata pruning.
This commit uses the dataset's actual epoch-day ranges, so Q36-Q42 process the intended July 2013 rows instead of returning empty results.