Conversation
|
|
Claude finished @punkbit's task in 1m 29s —— View job PR Review: chore(maintenance): 🤖 upgrade vite to v8
Good work on the migration! The changes are well-structured and all workarounds are clearly documented. This is a clean tooling upgrade with no impact on public component APIs. 💡 Suggestions (non-blocking)
No blocking issues. The |
6a51c10 to
3e4cbbc
Compare
|
Claude finished @punkbit's task in 1m 5s —— View job PR Review: chore(maintenance): 🤖 upgrade vite to v8
Clean tooling upgrade with no impact on public component APIs. All migration steps ( 💡 Suggestions (non-blocking)
No blocking issues. Nice work keeping the build tooling current! 🙌 |
package.json
Outdated
| "@storybook/addon-docs": "^10.1.10", | ||
| "@storybook/addon-links": "^10.1.10", | ||
| "@storybook/react-vite": "^10.1.10", | ||
| "@storybook/addon-a11y": "10.3.0-alpha.16", |
There was a problem hiding this comment.
why are we pinning to an alpha version? can we just wait to update until these are supported in the non-alpha versions?
There was a problem hiding this comment.
The version which supports vite 8 at the time of writing (2 weeks ago). Today, I can see 10.3.1 is now released, so I'll update it once I switch to this branch
There was a problem hiding this comment.
Updated to latest available at time of writing.
|
Claude finished @punkbit's task in 1m 4s —— View job PR Review: chore(maintenance): 🤖 upgrade vite to v8
Clean tooling upgrade — no impact on public component APIs. The What's improved since the last review cycle:
💡 Suggestion (non-blocking — flagged in previous reviews, still present)
No blocking issues. 🙌 |
|
Claude finished @punkbit's task in 54s —— View job PR Review: chore(maintenance): 🤖 upgrade vite to v8
Clean tooling upgrade — no impact on public component APIs. The What's improved since last review:
💡 Suggestion (non-blocking — flagged in 3 prior review cycles, still present)
No blocking issues. Nice work keeping the build tooling current! 🙌 |
📚 Storybook Preview Deployed✅ Preview URL: https://click-960yr6zr4-clickhouse.vercel.app Built from commit: |
Why?
This upgrade vite to the latest v8 by keeping the current project's build tooling or setup. Consequently, storybooks have also upgraded to the 10.3.0 version for compatibility with Vite 8.
⏳ The branch/PR will be kept on the side for further iterations and confirmation's healthy.
How?
Preview?
N/A