Extract the ClickPipes runtime and finalize the cloud CLI split - #402
Merged
sdairs merged 1 commit intoAug 13, 2026
Merged
Conversation
sdairs
temporarily deployed
to
cloud-integration
August 7, 2026 22:16 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Finalizes the per-domain cloud CLI layout by removing the generic cloud ClickPipes runtime module and moving all ClickPipes dispatch/handlers/builders/parsers/wrappers/tests into the clickpipes domain module, leaving cloud/mod.rs, cloud/cli.rs, and cloud/client.rs with shared/top-level responsibilities only.
Changes:
- Removed the generic
cloud/commands.rsmonolith and delegatedCloudCommands::ClickPipedispatch toclickpipes::run. - Moved ClickPipes runtime (handlers, request builders, file/base64 parsing, output) plus
CloudClientwrapper methods and unit tests intosrc/cloud/clickpipes.rs. - Updated contributor guidance and CI integration path filters to match the final per-domain layout.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/clickhousectl/src/cloud/mod.rs | Removes commands module usage and delegates ClickPipes dispatch to the ClickPipes domain runtime. |
| crates/clickhousectl/src/cloud/commands.rs | Deleted the generic cloud commands monolith (previous home of ClickPipes runtime). |
| crates/clickhousectl/src/cloud/client.rs | Removes ClickPipes-specific wrapper methods, leaving core client/auth/error/shared helpers. |
| crates/clickhousectl/src/cloud/clickpipes.rs | Becomes the single home for ClickPipes clap defs + runtime + builders + CloudClient wrappers + tests. |
| crates/clickhousectl/src/cloud/cli.rs | Narrows cloud CLI facade to top-level enums and crate-internal domain re-exports. |
| AGENTS.md | Updates contributor instructions to the final per-domain command pattern. |
| .github/workflows/cloud-integration.yml | Broadens the ClickHousectl cloud source path filter to src/cloud/** for the new layout. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sdairs
force-pushed
the
issue-385-clickpipes-runtime-finalize
branch
from
August 8, 2026 18:37
ee4566c to
317e7db
Compare
sdairs
had a problem deploying
to
cloud-integration
August 8, 2026 18:37 — with
GitHub Actions
Failure
sdairs
temporarily deployed
to
cloud-integration
August 8, 2026 18:45 — with
GitHub Actions
Inactive
sdairs
force-pushed
the
issue-385-clickpipes-runtime-finalize
branch
from
August 13, 2026 11:37
317e7db to
a4dddd2
Compare
sdairs
had a problem deploying
to
cloud-integration
August 13, 2026 11:38 — with
GitHub Actions
Failure
sdairs
had a problem deploying
to
cloud-integration
August 13, 2026 11:48 — with
GitHub Actions
Failure
sdairs
force-pushed
the
issue-385-clickpipes-runtime-finalize
branch
from
August 13, 2026 18:29
a4dddd2 to
97a0c90
Compare
This was referenced Aug 13, 2026
sdairs
had a problem deploying
to
cloud-integration
August 13, 2026 18:56 — with
GitHub Actions
Failure
sdairs
temporarily deployed
to
cloud-integration
August 13, 2026 19:10 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #385
Summary
Tests
cargo fmt --all --checkcargo test -p clickhousectlcargo check --workspace --all-featurescargo clippy --workspace --all-targets -- -D warnings